Fix microsoft#52274 - don't move focus when clicking the find option buttons with screenreader mode turned on, because NVDA sends click events instead of key events when pressing space on a focused button

roblourens · roblourens · commit 4cd9739394fa · 2018-09-21T13:46:45.000-07:00
diff --git a/src/vs/base/browser/ui/findinput/findInput.ts b/src/vs/base/browser/ui/findinput/findInput.ts
@@ -46,6 +46,7 @@ export class FindInput extends Widget {
 	private placeholder: string;
 	private validation: IInputValidator;
 	private label: string;
+	private fixFocusOnOptionClickEnabled = true;
 
 	private inputActiveOptionBorder: Color;
 	private inputBackground: Color;
@@ -146,6 +147,10 @@ export class FindInput extends Widget {
 		this.caseSensitive.disable();
 	}
 
+	public setFocusInputOnOptionClick(value: boolean): void {
+		this.fixFocusOnOptionClickEnabled = value;
+	}
+
 	public setEnabled(enabled: boolean): void {
 		if (enabled) {
 			this.enable();
@@ -312,7 +317,7 @@ export class FindInput extends Widget {
 		}));
 		this._register(this.regex.onChange(viaKeyboard => {
 			this._onDidOptionChange.fire(viaKeyboard);
-			if (!viaKeyboard) {
+			if (!viaKeyboard && this.fixFocusOnOptionClickEnabled) {
 				this.inputBox.focus();
 			}
 			this.setInputWidth();
@@ -329,7 +334,7 @@ export class FindInput extends Widget {
 		}));
 		this._register(this.wholeWords.onChange(viaKeyboard => {
 			this._onDidOptionChange.fire(viaKeyboard);
-			if (!viaKeyboard) {
+			if (!viaKeyboard && this.fixFocusOnOptionClickEnabled) {
 				this.inputBox.focus();
 			}
 			this.setInputWidth();
@@ -343,7 +348,7 @@ export class FindInput extends Widget {
 		}));
 		this._register(this.caseSensitive.onChange(viaKeyboard => {
 			this._onDidOptionChange.fire(viaKeyboard);
-			if (!viaKeyboard) {
+			if (!viaKeyboard && this.fixFocusOnOptionClickEnabled) {
 				this.inputBox.focus();
 			}
 			this.setInputWidth();
diff --git a/src/vs/editor/contrib/find/findWidget.ts b/src/vs/editor/contrib/find/findWidget.ts
@@ -159,7 +159,12 @@ export class FindWidget extends Widget implements IOverlayWidget, IHorizontalSas
 			if (e.layoutInfo) {
 				this._tryUpdateWidgetWidth();
 			}
+
+			if (e.accessibilitySupport) {
+				this.updateAccessibilitySupport();
+			}
 		}));
+		this.updateAccessibilitySupport();
 		this._register(this._codeEditor.onDidChangeCursorSelection(() => {
 			if (this._isVisible) {
 				this._updateToggleSelectionFindButton();
@@ -840,6 +845,8 @@ export class FindWidget extends Widget implements IOverlayWidget, IHorizontalSas
 
 		findPart.appendChild(this._closeBtn.domNode);
 
+		this.updateAccessibilitySupport();
+
 		return findPart;
 	}
 
@@ -959,6 +966,11 @@ export class FindWidget extends Widget implements IOverlayWidget, IHorizontalSas
 			}
 		}));
 	}
+
+	private updateAccessibilitySupport(): void {
+		const value = this._codeEditor.getConfiguration().accessibilitySupport;
+		this._findInput.setFocusInputOnOptionClick(value !== platform.AccessibilitySupport.Enabled);
+	}
 }
 
 interface ISimpleCheckboxOpts {
diff --git a/src/vs/workbench/parts/search/browser/searchView.ts b/src/vs/workbench/parts/search/browser/searchView.ts
@@ -323,7 +323,7 @@ export class SearchView extends Viewlet implements IViewlet, IPanel {
 
 		this._register(this.searchWidget.onSearchSubmit(() => this.onQueryChanged()));
 		this._register(this.searchWidget.onSearchCancel(() => this.cancelSearch()));
-		this._register(this.searchWidget.searchInput.onDidOptionChange((viaKeyboard) => this.onQueryChanged(viaKeyboard)));
+		this._register(this.searchWidget.searchInput.onDidOptionChange(() => this.onQueryChanged(true)));
 
 		this._register(this.searchWidget.onReplaceToggled(() => this.onReplaceToggled()));
 		this._register(this.searchWidget.onReplaceStateChange((state) => {
diff --git a/src/vs/workbench/parts/search/browser/searchWidget.ts b/src/vs/workbench/parts/search/browser/searchWidget.ts
@@ -136,6 +136,13 @@ export class SearchWidget extends Widget {
 		this.replaceInputBoxFocused = Constants.ReplaceInputBoxFocusedKey.bindTo(this.contextKeyService);
 		this._replaceHistoryDelayer = new Delayer<void>(500);
 		this.render(container, options);
+
+		this.configurationService.onDidChangeConfiguration(e => {
+			if (e.affectsConfiguration('editor.accessibilitySupport')) {
+				this.updateAccessibilitySupport();
+			}
+		});
+		this.updateAccessibilitySupport();
 	}
 
 	public focus(select: boolean = true, focusReplace: boolean = false, suppressGlobalSearchBuffer = false): void {
@@ -237,6 +244,11 @@ export class SearchWidget extends Widget {
 		this.renderReplaceInput(this.domNode, options);
 	}
 
+	private updateAccessibilitySupport(): void {
+		const value = this.configurationService.getValue('editor.accessibilitySupport');
+		this.searchInput.setFocusInputOnOptionClick(value !== 'on');
+	}
+
 	private renderToggleReplaceButton(parent: HTMLElement): void {
 		const opts: IButtonOptions = {
 			buttonBackground: null,

Original file line number	Diff line number	Diff line change
`@@ -159,7 +159,12 @@ export class FindWidget extends Widget implements IOverlayWidget, IHorizontalSas`
`159`	`159`	`if (e.layoutInfo) {`
`160`	`160`	`this._tryUpdateWidgetWidth();`
`161`	`161`	`}`
	`162`	`+`
	`163`	`+ if (e.accessibilitySupport) {`
	`164`	`+ this.updateAccessibilitySupport();`
	`165`	`+ }`
`162`	`166`	`}));`
	`167`	`+ this.updateAccessibilitySupport();`
`163`	`168`	`this._register(this._codeEditor.onDidChangeCursorSelection(() => {`
`164`	`169`	`if (this._isVisible) {`
`165`	`170`	`this._updateToggleSelectionFindButton();`
`@@ -840,6 +845,8 @@ export class FindWidget extends Widget implements IOverlayWidget, IHorizontalSas`
`840`	`845`
`841`	`846`	`findPart.appendChild(this._closeBtn.domNode);`
`842`	`847`
	`848`	`+ this.updateAccessibilitySupport();`
	`849`	`+`
`843`	`850`	`return findPart;`
`844`	`851`	`}`
`845`	`852`
`@@ -959,6 +966,11 @@ export class FindWidget extends Widget implements IOverlayWidget, IHorizontalSas`
`959`	`966`	`}`
`960`	`967`	`}));`
`961`	`968`	`}`
	`969`	`+`
	`970`	`+ private updateAccessibilitySupport(): void {`
	`971`	`+ const value = this._codeEditor.getConfiguration().accessibilitySupport;`
	`972`	`+ this._findInput.setFocusInputOnOptionClick(value !== platform.AccessibilitySupport.Enabled);`
	`973`	`+ }`
`962`	`974`	`}`
`963`	`975`
`964`	`976`	`interface ISimpleCheckboxOpts {`