Support multi-line environment variables

Tyriar · Tyriar · commit 4cd1c0fcebe9 · 2016-03-24T09:51:55.000-07:00
A standard Fedora install comes with 2 multiple line environment variables. Since `env` was previously split by '\n' this would break them, causing errors in the output pane and in terminals launched through the file explorer (see microsoft#3495). Fixes microsoft#3928
diff --git a/src/vs/base/node/env.ts b/src/vs/base/node/env.ts
@@ -19,7 +19,8 @@ export function getUserEnvironment(): TPromise<IEnv> {
 	}
 
 	return new TPromise((c, e) => {
-		let child = cp.spawn(process.env.SHELL, ['-ilc', 'env'], {
+		// Use --null and split by '\0' as splitting by '\n' breaks multi-line environment variables
+		let child = cp.spawn(process.env.SHELL, ['-ilc', 'env', '--null'], {
 			detached: true,
 			stdio: ['ignore', 'pipe', process.stderr],
 		});
@@ -37,7 +38,7 @@ export function getUserEnvironment(): TPromise<IEnv> {
 
 			let result: IEnv = Object.create(null);
 
-			buffer.split('\n').forEach(line => {
+			buffer.split('\0').forEach(line => {
 				let pos = line.indexOf('=');
 				if (pos > 0) {
 					let key = line.substring(0, pos);
