Skip to content

Commit 4beb0d5

Browse files
author
Benjamin Pasero
committed
debt - limiter(1) => queue
1 parent 196b1b2 commit 4beb0d5

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

src/vs/platform/extensionManagement/node/extensionManagementService.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ import {
2424
import { getGalleryExtensionIdFromLocal, adoptToGalleryExtensionId, areSameExtensions, getGalleryExtensionId, groupByExtension, getMaliciousExtensionsSet, getLocalExtensionId, getGalleryExtensionTelemetryData, getLocalExtensionTelemetryData, getIdFromLocalExtensionId } from 'vs/platform/extensionManagement/common/extensionManagementUtil';
2525
import { localizeManifest } from '../common/extensionNls';
2626
import { IEnvironmentService } from 'vs/platform/environment/common/environment';
27-
import { Limiter, always, createCancelablePromise, CancelablePromise } from 'vs/base/common/async';
27+
import { Limiter, always, createCancelablePromise, CancelablePromise, Queue } from 'vs/base/common/async';
2828
import { Event, Emitter } from 'vs/base/common/event';
2929
import * as semver from 'semver';
3030
import { URI } from 'vs/base/common/uri';
@@ -114,7 +114,7 @@ export class ExtensionManagementService extends Disposable implements IExtension
114114
private systemExtensionsPath: string;
115115
private extensionsPath: string;
116116
private uninstalledPath: string;
117-
private uninstalledFileLimiter: Limiter<void>;
117+
private uninstalledFileLimiter: Queue<void>;
118118
private reportedExtensions: Promise<IReportedExtension[]> | undefined;
119119
private lastReportTimestamp = 0;
120120
private readonly installingExtensions: Map<string, CancelablePromise<void>> = new Map<string, CancelablePromise<void>>();
@@ -146,7 +146,7 @@ export class ExtensionManagementService extends Disposable implements IExtension
146146
this.systemExtensionsPath = environmentService.builtinExtensionsPath;
147147
this.extensionsPath = environmentService.extensionsPath;
148148
this.uninstalledPath = path.join(this.extensionsPath, '.obsolete');
149-
this.uninstalledFileLimiter = new Limiter(1);
149+
this.uninstalledFileLimiter = new Queue<void>();
150150
this.manifestCache = this._register(new ExtensionsManifestCache(environmentService, this));
151151
this.extensionLifecycle = this._register(new ExtensionsLifecycle(this.logService));
152152

src/vs/platform/localizations/node/localizations.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import { IExtensionManagementService, ILocalExtension, IExtensionIdentifier } fr
99
import { Disposable } from 'vs/base/common/lifecycle';
1010
import { IEnvironmentService } from 'vs/platform/environment/common/environment';
1111
import { TPromise } from 'vs/base/common/winjs.base';
12-
import { Limiter } from 'vs/base/common/async';
12+
import { Queue } from 'vs/base/common/async';
1313
import { areSameExtensions, getGalleryExtensionIdFromLocal, getIdFromLocalExtensionId } from 'vs/platform/extensionManagement/common/extensionManagementUtil';
1414
import { ILogService } from 'vs/platform/log/common/log';
1515
import { isValidLocalization, ILocalizationsService, LanguageType } from 'vs/platform/localizations/common/localizations';
@@ -100,15 +100,15 @@ class LanguagePacksCache extends Disposable {
100100

101101
private languagePacks: { [language: string]: ILanguagePack } = {};
102102
private languagePacksFilePath: string;
103-
private languagePacksFileLimiter: Limiter<void>;
103+
private languagePacksFileLimiter: Queue<void>;
104104

105105
constructor(
106106
@IEnvironmentService environmentService: IEnvironmentService,
107107
@ILogService private logService: ILogService
108108
) {
109109
super();
110110
this.languagePacksFilePath = posix.join(environmentService.userDataPath, 'languagepacks.json');
111-
this.languagePacksFileLimiter = new Limiter(1);
111+
this.languagePacksFileLimiter = new Queue<void>();
112112
}
113113

114114
getLanguagePacks(): TPromise<{ [language: string]: ILanguagePack }> {

0 commit comments

Comments
 (0)