Fixes microsoft#27348: Task should not be drop if identifier is undefined

dbaeumer · dbaeumer · commit 4bb81e3099a0 · 2017-05-30T22:03:57.000+02:00
diff --git a/src/vs/workbench/api/node/extHostTask.ts b/src/vs/workbench/api/node/extHostTask.ts
@@ -294,7 +294,7 @@ namespace Tasks {
 	}
 
 	function fromSingle(task: vscode.Task, extension: IExtensionDescription, uuidMap: UUIDMap): TaskSystem.Task {
-		if (typeof task.name !== 'string' || typeof task.identifier !== 'string') {
+		if (typeof task.name !== 'string') {
 			return undefined;
 		}
 		let command: TaskSystem.CommandConfiguration;

Original file line number	Diff line number	Diff line change
`@@ -294,7 +294,7 @@ namespace Tasks {`
`294`	`294`	`}`
`295`	`295`
`296`	`296`	`function fromSingle(task: vscode.Task, extension: IExtensionDescription, uuidMap: UUIDMap): TaskSystem.Task {`
`297`		`- if (typeof task.name !== 'string' \|\| typeof task.identifier !== 'string') {`
	`297`	`+ if (typeof task.name !== 'string') {`
`298`	`298`	`return undefined;`
`299`	`299`	`}`
`300`	`300`	`let command: TaskSystem.CommandConfiguration;`