Skip to content

Commit 4af9b3e

Browse files
committed
limit once per 10s
1 parent 65cc975 commit 4af9b3e

2 files changed

Lines changed: 5 additions & 6 deletions

File tree

src/vs/platform/userDataSync/common/userDataAutoSyncService.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -126,12 +126,12 @@ export class UserDataAutoSyncService extends Disposable implements IUserDataAuto
126126

127127
/*
128128
If sync is not triggered by sync resource (triggered by other sources like window focus etc.,)
129-
then limit sync to once per minute
129+
then limit sync to once per 10s
130130
*/
131131
const isNotTriggeredBySyncResource = ALL_SYNC_RESOURCES.every(syncResource => sources.indexOf(syncResource) === -1);
132132
if (isNotTriggeredBySyncResource && this.lastSyncTriggerTime
133-
&& Math.round((new Date().getTime() - this.lastSyncTriggerTime) / 1000) < 60) {
134-
this.logService.debug('Auto Sync Skipped: Limited to once per minute.');
133+
&& Math.round((new Date().getTime() - this.lastSyncTriggerTime) / 1000) < 10) {
134+
this.logService.debug('Auto Sync Skipped: Limited to once per 10 seconds.');
135135
return;
136136
}
137137

src/vs/platform/userDataSync/test/common/userDataAutoSyncService.test.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,12 +53,11 @@ suite('UserDataAutoSyncService', () => {
5353
const testObject: UserDataAutoSyncService = client.instantiationService.createInstance(TestUserDataAutoSyncService);
5454

5555
// Trigger auto sync with settings change multiple times
56-
for (let counter = 0; counter < 3; counter++) {
56+
for (let counter = 0; counter < 2; counter++) {
5757
await testObject.triggerAutoSync([SyncResource.Settings]);
5858
}
5959

6060
assert.deepEqual(target.requests, [
61-
{ type: 'GET', url: `${target.url}/v1/manifest`, headers: {} },
6261
{ type: 'GET', url: `${target.url}/v1/manifest`, headers: {} },
6362
{ type: 'GET', url: `${target.url}/v1/manifest`, headers: {} }
6463
]);
@@ -98,7 +97,7 @@ suite('UserDataAutoSyncService', () => {
9897
const testObject: UserDataAutoSyncService = client.instantiationService.createInstance(TestUserDataAutoSyncService);
9998

10099
// Trigger auto sync with window focus multiple times
101-
for (let counter = 0; counter < 3; counter++) {
100+
for (let counter = 0; counter < 2; counter++) {
102101
await testObject.triggerAutoSync(['windowFocus']);
103102
}
104103

0 commit comments

Comments
 (0)