Skip to content

Commit 49c62cb

Browse files
committed
fix uri-test (do not assume URL work alike cross browser...) microsoft#93362
1 parent 72df4fc commit 49c62cb

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

src/vs/base/test/common/uri.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -538,7 +538,7 @@ suite('URI', () => {
538538
assert.throws(() => assertJoined(('foo:'), 'bazz', ''));
539539
assert.throws(() => new URL('bazz', 'foo:'));
540540
assert.throws(() => assertJoined(('foo://bar'), 'bazz', ''));
541-
// assert.throws(() => new URL('bazz', 'foo://bar')); Edge,Chrome => throw, Safari => foo://bar/bazz, Firefox ??
541+
// assert.throws(() => new URL('bazz', 'foo://bar')); Edge, Chrome => THROW, Firefox, Safari => foo://bar/bazz
542542
});
543543

544544
test('URI#joinPath (posix)', function () {
@@ -549,8 +549,8 @@ suite('URI', () => {
549549
assertJoined(('file://server/share/c:/'), '../../bazz', 'file://server/bazz', false);
550550
assertJoined(('file://server/share/c:'), '../../bazz', 'file://server/bazz', false);
551551

552-
assertJoined(('file://ser/foo/'), '../../bazz', 'file://ser/bazz');
553-
assertJoined(('file://ser/foo'), '../../bazz', 'file://ser/bazz');
552+
assertJoined(('file://ser/foo/'), '../../bazz', 'file://ser/bazz', false); // Firefox -> Different, Edge, Chrome, Safar -> OK
553+
assertJoined(('file://ser/foo'), '../../bazz', 'file://ser/bazz', false); // Firefox -> Different, Edge, Chrome, Safar -> OK
554554
});
555555

556556
test('URI#joinPath (windows)', function () {

0 commit comments

Comments
 (0)