💄 when disposing all lenses, microsoft#84726

jrieken · jrieken · commit 485fdf8beac1 · 2019-11-14T17:56:46.000+01:00
diff --git a/src/vs/editor/contrib/codelens/codelensController.ts b/src/vs/editor/contrib/codelens/codelensController.ts
@@ -222,8 +222,10 @@ export class CodeLensContribution implements editorCommon.IEditorContribution {
 	}
 
 	private _disposeAllLenses(decChangeAccessor: IModelDecorationsChangeAccessor | undefined, viewZoneChangeAccessor: editorBrowser.IViewZoneChangeAccessor | undefined): void {
-		let helper = new CodeLensHelper();
-		this._lenses.forEach((lens) => lens.dispose(helper, viewZoneChangeAccessor));
+		const helper = new CodeLensHelper();
+		for (const lens of this._lenses) {
+			lens.dispose(helper, viewZoneChangeAccessor);
+		}
 		if (decChangeAccessor) {
 			helper.commit(decChangeAccessor);
 		}

Original file line number	Diff line number	Diff line change
`@@ -222,8 +222,10 @@ export class CodeLensContribution implements editorCommon.IEditorContribution {`
`222`	`222`	`}`
`223`	`223`
`224`	`224`	`private _disposeAllLenses(decChangeAccessor: IModelDecorationsChangeAccessor \| undefined, viewZoneChangeAccessor: editorBrowser.IViewZoneChangeAccessor \| undefined): void {`
`225`		`- let helper = new CodeLensHelper();`
`226`		`- this._lenses.forEach((lens) => lens.dispose(helper, viewZoneChangeAccessor));`
	`225`	`+ const helper = new CodeLensHelper();`
	`226`	`+ for (const lens of this._lenses) {`
	`227`	`+ lens.dispose(helper, viewZoneChangeAccessor);`
	`228`	`+ }`
`227`	`229`	`if (decChangeAccessor) {`
`228`	`230`	`helper.commit(decChangeAccessor);`
`229`	`231`	`}`