Add extra loging for parameter hints hasDocs

mjbvz · mjbvz · commit 48539eea8b33 · 2020-05-14T17:03:16.000-07:00
Fixes microsoft#97448
diff --git a/src/vs/editor/contrib/parameterHints/parameterHintsWidget.ts b/src/vs/editor/contrib/parameterHints/parameterHintsWidget.ts
@@ -24,6 +24,7 @@ import { HIGH_CONTRAST, registerThemingParticipant } from 'vs/platform/theme/com
 import { ParameterHintsModel, TriggerContext } from 'vs/editor/contrib/parameterHints/parameterHintsModel';
 import { pad } from 'vs/base/common/strings';
 import { registerIcon, Codicon } from 'vs/base/common/codicons';
+import { assertIsDefined } from 'vs/base/common/types';
 
 const $ = dom.$;
 
@@ -263,16 +264,16 @@ export class ParameterHintsWidget extends Disposable implements IContentWidget {
 	}
 
 	private hasDocs(signature: modes.SignatureInformation, activeParameter: modes.ParameterInformation | undefined): boolean {
-		if (activeParameter && typeof activeParameter.documentation === 'string' && activeParameter.documentation.length > 0) {
+		if (activeParameter && typeof activeParameter.documentation === 'string' && assertIsDefined(activeParameter.documentation).length > 0) {
 			return true;
 		}
-		if (activeParameter && typeof activeParameter.documentation === 'object' && activeParameter.documentation.value.length > 0) {
+		if (activeParameter && typeof activeParameter.documentation === 'object' && assertIsDefined(activeParameter.documentation).value.length > 0) {
 			return true;
 		}
-		if (typeof signature.documentation === 'string' && signature.documentation.length > 0) {
+		if (signature.documentation && typeof signature.documentation === 'string' && assertIsDefined(signature.documentation).length > 0) {
 			return true;
 		}
-		if (typeof signature.documentation === 'object' && signature.documentation.value.length > 0) {
+		if (signature.documentation && typeof signature.documentation === 'object' && assertIsDefined(signature.documentation.value).length > 0) {
 			return true;
 		}
 		return false;

Original file line number	Diff line number	Diff line change
`@@ -24,6 +24,7 @@ import { HIGH_CONTRAST, registerThemingParticipant } from 'vs/platform/theme/com`
`24`	`24`	`import { ParameterHintsModel, TriggerContext } from 'vs/editor/contrib/parameterHints/parameterHintsModel';`
`25`	`25`	`import { pad } from 'vs/base/common/strings';`
`26`	`26`	`import { registerIcon, Codicon } from 'vs/base/common/codicons';`
	`27`	`+import { assertIsDefined } from 'vs/base/common/types';`
`27`	`28`
`28`	`29`	`const $ = dom.$;`
`29`	`30`
`@@ -263,16 +264,16 @@ export class ParameterHintsWidget extends Disposable implements IContentWidget {`
`263`	`264`	`}`
`264`	`265`
`265`	`266`	`private hasDocs(signature: modes.SignatureInformation, activeParameter: modes.ParameterInformation \| undefined): boolean {`
`266`		`- if (activeParameter && typeof activeParameter.documentation === 'string' && activeParameter.documentation.length > 0) {`
	`267`	`+ if (activeParameter && typeof activeParameter.documentation === 'string' && assertIsDefined(activeParameter.documentation).length > 0) {`
`267`	`268`	`return true;`
`268`	`269`	`}`
`269`		`- if (activeParameter && typeof activeParameter.documentation === 'object' && activeParameter.documentation.value.length > 0) {`
	`270`	`+ if (activeParameter && typeof activeParameter.documentation === 'object' && assertIsDefined(activeParameter.documentation).value.length > 0) {`
`270`	`271`	`return true;`
`271`	`272`	`}`
`272`		`- if (typeof signature.documentation === 'string' && signature.documentation.length > 0) {`
	`273`	`+ if (signature.documentation && typeof signature.documentation === 'string' && assertIsDefined(signature.documentation).length > 0) {`
`273`	`274`	`return true;`
`274`	`275`	`}`
`275`		`- if (typeof signature.documentation === 'object' && signature.documentation.value.length > 0) {`
	`276`	`+ if (signature.documentation && typeof signature.documentation === 'object' && assertIsDefined(signature.documentation.value).length > 0) {`
`276`	`277`	`return true;`
`277`	`278`	`}`
`278`	`279`	`return false;`