Update api to avoid casts in tests

mjbvz · mjbvz · commit 46859507daf1 · 2018-12-17T17:12:08.000-08:00
diff --git a/src/vs/editor/contrib/snippet/snippetParser.ts b/src/vs/editor/contrib/snippet/snippetParser.ts
@@ -373,7 +373,7 @@ export class FormatString extends Marker {
 		super();
 	}
 
-	resolve(value: string): string {
+	resolve(value?: string): string {
 		if (this.shorthandName === 'upcase') {
 			return !value ? '' : value.toLocaleUpperCase();
 		} else if (this.shorthandName === 'downcase') {
diff --git a/src/vs/editor/contrib/snippet/test/snippetParser.test.ts b/src/vs/editor/contrib/snippet/test/snippetParser.test.ts
@@ -657,17 +657,17 @@ suite('SnippetParser', () => {
 		assert.equal(new FormatString(1, 'notKnown').resolve('input'), 'input');
 
 		// if
-		assert.equal(new FormatString(1, undefined, 'foo', undefined).resolve((undefined as any as string)), '');
+		assert.equal(new FormatString(1, undefined, 'foo', undefined).resolve(undefined), '');
 		assert.equal(new FormatString(1, undefined, 'foo', undefined).resolve(''), '');
 		assert.equal(new FormatString(1, undefined, 'foo', undefined).resolve('bar'), 'foo');
 
 		// else
-		assert.equal(new FormatString(1, undefined, undefined, 'foo').resolve((undefined as any as string)), 'foo');
+		assert.equal(new FormatString(1, undefined, undefined, 'foo').resolve(undefined), 'foo');
 		assert.equal(new FormatString(1, undefined, undefined, 'foo').resolve(''), 'foo');
 		assert.equal(new FormatString(1, undefined, undefined, 'foo').resolve('bar'), 'bar');
 
 		// if-else
-		assert.equal(new FormatString(1, undefined, 'bar', 'foo').resolve((undefined as any as string)), 'foo');
+		assert.equal(new FormatString(1, undefined, 'bar', 'foo').resolve(undefined), 'foo');
 		assert.equal(new FormatString(1, undefined, 'bar', 'foo').resolve(''), 'foo');
 		assert.equal(new FormatString(1, undefined, 'bar', 'foo').resolve('baz'), 'bar');
 	});

Original file line number	Diff line number	Diff line change
`@@ -373,7 +373,7 @@ export class FormatString extends Marker {`
`373`	`373`	`super();`
`374`	`374`	`}`
`375`	`375`
`376`		`- resolve(value: string): string {`
	`376`	`+ resolve(value?: string): string {`
`377`	`377`	`if (this.shorthandName === 'upcase') {`
`378`	`378`	`return !value ? '' : value.toLocaleUpperCase();`
`379`	`379`	`} else if (this.shorthandName === 'downcase') {`