Skip to content

Commit 465fc4f

Browse files
author
Benjamin Pasero
committed
more linting in workbench
1 parent 54782e5 commit 465fc4f

40 files changed

Lines changed: 70 additions & 126 deletions

src/vs/workbench/browser/actionRegistry.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,20 +4,17 @@
44
*--------------------------------------------------------------------------------------------*/
55
'use strict';
66

7-
import nls = require('vs/nls');
87
import {TPromise} from 'vs/base/common/winjs.base';
98
import collections = require('vs/base/common/collections');
109
import {Registry} from 'vs/platform/platform';
1110
import {IAction} from 'vs/base/common/actions';
1211
import {KeybindingsRegistry,ICommandDescriptor} from 'vs/platform/keybinding/common/keybindingsRegistry';
13-
import {KeybindingsUtils} from 'vs/platform/keybinding/common/keybindingsUtils';
1412
import {IPartService} from 'vs/workbench/services/part/common/partService';
1513
import {ICommandHandler} from 'vs/platform/keybinding/common/keybindingService';
1614
import {SyncActionDescriptor} from 'vs/platform/actions/common/actions';
17-
import {IMessageService, IMessageWithAction} from 'vs/platform/message/common/message';
15+
import {IMessageService} from 'vs/platform/message/common/message';
1816
import {ITelemetryService} from 'vs/platform/telemetry/common/telemetry';
1917
import {IInstantiationService} from 'vs/platform/instantiation/common/instantiation';
20-
import {Keybinding} from 'vs/base/common/keyCodes';
2118
import Severity from 'vs/base/common/severity';
2219

2320
export const Extensions = {
@@ -82,7 +79,6 @@ class WorkbenchActionRegistry implements IWorkbenchActionRegistry {
8279
return false;
8380
}
8481

85-
let descriptor = this.workbenchActions[id];
8682
delete this.workbenchActions[id];
8783
delete this.mapActionIdToCategory[id];
8884

src/vs/workbench/browser/component.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
*--------------------------------------------------------------------------------------------*/
55
'use strict';
66

7-
import {TPromise} from 'vs/base/common/winjs.base';
87
import {EventEmitter, IEventEmitter} from 'vs/base/common/eventEmitter';
98
import {IDisposable} from 'vs/base/common/lifecycle';
109
import {Scope, Memento} from 'vs/workbench/common/memento';

src/vs/workbench/browser/layout.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import {IWorkbenchEditorService} from 'vs/workbench/services/editor/common/edito
1414
import {IPartService, Position} from 'vs/workbench/services/part/common/partService';
1515
import {IWorkspaceContextService} from 'vs/workbench/services/workspace/common/contextService';
1616
import {IStorageService, StorageScope, StorageEventType} from 'vs/platform/storage/common/storage';
17-
import {IContextViewService, IContextMenuService} from 'vs/platform/contextview/browser/contextView';
17+
import {IContextViewService} from 'vs/platform/contextview/browser/contextView';
1818
import {IEventService} from 'vs/platform/event/common/event';
1919

2020
const DEFAULT_MIN_PART_WIDTH = 170;

src/vs/workbench/browser/parts/activitybar/activitybarPart.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ import {IInstantiationService} from 'vs/platform/instantiation/common/instantiat
2828
import {IMessageService, Severity} from 'vs/platform/message/common/message';
2929
import {ITelemetryService} from 'vs/platform/telemetry/common/telemetry';
3030
import {IKeybindingService} from 'vs/platform/keybinding/common/keybindingService';
31-
import {KeybindingsUtils} from 'vs/platform/keybinding/common/keybindingsUtils';
3231

3332
export class ActivitybarPart extends Part implements IActivityService {
3433
public serviceId = IActivityService;

src/vs/workbench/browser/parts/editor/baseEditor.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import {Action, IAction} from 'vs/base/common/actions';
99
import {ActionBarContributor} from 'vs/workbench/browser/actionBarRegistry';
1010
import types = require('vs/base/common/types');
1111
import {Builder} from 'vs/base/browser/builder';
12-
import URI from 'vs/base/common/uri';
1312
import {Registry} from 'vs/platform/platform';
1413
import {Viewlet} from 'vs/workbench/browser/viewlet';
1514
import {EditorInput, IFileEditorInput, EditorOptions} from 'vs/workbench/common/editor';

src/vs/workbench/browser/parts/editor/binaryEditor.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77

88
import 'vs/css!./media/binaryeditor';
99
import nls = require('vs/nls');
10-
import DOM = require('vs/base/browser/dom');
1110
import {TPromise} from 'vs/base/common/winjs.base';
1211
import {Dimension, Builder, $} from 'vs/base/browser/builder';
1312
import {ResourceViewer} from 'vs/base/browser/ui/resourceviewer/resourceViewer';

src/vs/workbench/browser/parts/editor/editor.contribution.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ import {UntitledEditorInput} from 'vs/workbench/browser/parts/editor/untitledEdi
1515
import {ResourceEditorInput} from 'vs/workbench/browser/parts/editor/resourceEditorInput';
1616
import {TextDiffEditor} from 'vs/workbench/browser/parts/editor/textDiffEditor';
1717
import {BinaryResourceDiffEditor} from 'vs/workbench/browser/parts/editor/binaryDiffEditor';
18-
import {BinaryResourceEditor} from 'vs/workbench/browser/parts/editor/binaryEditor';
1918
import {IFrameEditor} from 'vs/workbench/browser/parts/editor/iframeEditor';
2019
import {IFrameEditorInput} from 'vs/workbench/browser/parts/editor/iframeEditorInput';
2120
import {ChangeEncodingAction, ChangeEOLAction, ChangeModeAction, EditorStatus} from 'vs/workbench/browser/parts/editor/editorStatus';

src/vs/workbench/browser/parts/editor/editorPart.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,6 @@ export class EditorPart extends Part implements IEditorPart {
6565
private instantiationService: IInstantiationService;
6666
private dimension: Dimension;
6767
private sideBySideControl: SideBySideEditorControl;
68-
private quickStartTimer: timer.ITimerEvent;
6968
private memento: any;
7069

7170
// The following data structures are partitioned into array of Position as provided by Services.POSITION array
@@ -212,7 +211,7 @@ export class EditorPart extends Part implements IEditorPart {
212211

213212
// To prevent race conditions, we call the close in a timeout because it can well be
214213
// that an input is being disposed with the intent to replace it with some other input
215-
// right after.
214+
// right after.
216215
setTimeout(() => {
217216
if (input === this.visibleInputs[position]) {
218217
this.closeEditors(false, input).done(null, errors.onUnexpectedError);

src/vs/workbench/browser/parts/editor/editorStatus.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,14 @@ import strings = require('vs/base/common/strings');
1515
import types = require('vs/base/common/types');
1616
import uri from 'vs/base/common/uri';
1717
import errors = require('vs/base/common/errors');
18-
import Severity from 'vs/base/common/severity';
1918
import {IStatusbarItem} from 'vs/workbench/browser/parts/statusbar/statusbar';
2019
import {Action} from 'vs/base/common/actions';
2120
import {IEditorModesRegistry, Extensions} from 'vs/editor/common/modes/modesRegistry';
2221
import {Registry} from 'vs/platform/platform';
2322
import {BaseEditor} from 'vs/workbench/browser/parts/editor/baseEditor';
2423
import {UntitledEditorInput} from 'vs/workbench/browser/parts/editor/untitledEditorInput';
25-
import {IFileEditorInput, EditorInput, EncodingMode, IEncodingSupport, asFileEditorInput, getUntitledOrFileResource} from 'vs/workbench/common/editor';
26-
import {toDisposable, IDisposable, combinedDispose} from 'vs/base/common/lifecycle';
24+
import {IFileEditorInput, EncodingMode, IEncodingSupport, asFileEditorInput, getUntitledOrFileResource} from 'vs/workbench/common/editor';
25+
import {IDisposable, combinedDispose} from 'vs/base/common/lifecycle';
2726
import {ICodeEditor, IDiffEditor} from 'vs/editor/browser/editorBrowser';
2827
import {EndOfLineSequence, ITokenizedModel, EditorType, IEditorSelection, ITextModel, IDiffEditorModel, IEditor} from 'vs/editor/common/editorCommon';
2928
import {EventType, EditorEvent, TextEditorSelectionEvent, ResourceEvent} from 'vs/workbench/browser/events';

src/vs/workbench/browser/parts/editor/resourceEditorInput.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
'use strict';
66

77
import {TPromise} from 'vs/base/common/winjs.base';
8-
import {MIME_TEXT} from 'vs/base/common/mime';
98
import {EditorModel, EditorInput} from 'vs/workbench/common/editor';
109
import {ResourceEditorModel} from 'vs/workbench/browser/parts/editor/resourceEditorModel';
1110
import URI from 'vs/base/common/uri';

0 commit comments

Comments
 (0)