continue to suppor legacy parameter hints config, microsoft#81256

jrieken · jrieken · commit 46043d41c8bf · 2019-10-02T12:24:52.000+02:00
diff --git a/src/vs/editor/common/config/editorOptions.ts b/src/vs/editor/common/config/editorOptions.ts
@@ -1871,14 +1871,25 @@ class EditorParameterHints extends BaseEditorOption<EditorOption.parameterHints,
 	}
 
 	public validate(_input: any): InternalParameterHintOptions {
-		if (typeof _input !== 'object') {
+		if (typeof _input === 'boolean') {
+			// legacy
+			return {
+				enabled: _input,
+				cycle: this.defaultValue.cycle
+			};
+
+		} else if (typeof _input !== 'object') {
+			// invalid
 			return this.defaultValue;
+
+		} else {
+			//
+			const input = _input as IEditorParameterHintOptions;
+			return {
+				enabled: EditorBooleanOption.boolean(input.enabled, this.defaultValue.enabled),
+				cycle: EditorBooleanOption.boolean(input.cycle, this.defaultValue.cycle)
+			};
 		}
-		const input = _input as IEditorParameterHintOptions;
-		return {
-			enabled: EditorBooleanOption.boolean(input.enabled, this.defaultValue.enabled),
-			cycle: EditorBooleanOption.boolean(input.cycle, this.defaultValue.cycle)
-		};
 	}
 }
 
