Skip to content

Commit 459f207

Browse files
author
Benjamin Pasero
committed
tslint - show warning when using path module from node.js
Instead clients need to use our base path module
1 parent e02f5dc commit 459f207

3 files changed

Lines changed: 17 additions & 17 deletions

File tree

‎package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "code-oss-dev",
33
"version": "1.39.0",
4-
"distro": "13ad3edfae7fc8e54c16b95b7ed4f5b6e41571ab",
4+
"distro": "b95ba5874a1c13644a3fcc82fa6c0b82f290215c",
55
"author": {
66
"name": "Microsoft Corporation"
77
},

‎src/vs/platform/dialogs/electron-main/dialogs.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import { MessageBoxOptions, MessageBoxReturnValue, SaveDialogOptions, SaveDialog
88
import { Queue } from 'vs/base/common/async';
99
import { IStateService } from 'vs/platform/state/node/state';
1010
import { isMacintosh } from 'vs/base/common/platform';
11-
import { dirname } from 'path';
11+
import { dirname } from 'vs/base/common/path';
1212
import { normalizeNFC } from 'vs/base/common/normalization';
1313
import { exists } from 'vs/base/node/pfs';
1414
import { INativeOpenDialogOptions } from 'vs/platform/dialogs/node/dialogs';

‎tslint.json‎

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@
9393
"restrictions": [
9494
"vs/nls",
9595
"**/vs/base/{common,browser,node}/**",
96-
"*" // node modules
96+
"!path" // node modules (except path where we have our own impl)
9797
]
9898
},
9999
{
@@ -129,7 +129,7 @@
129129
"vs/nls",
130130
"**/vs/base/{common,browser,node}/**",
131131
"**/vs/base/parts/*/{common,browser,node}/**",
132-
"*" // node modules
132+
"!path" // node modules (except path where we have our own impl)
133133
]
134134
},
135135
{
@@ -139,7 +139,7 @@
139139
"vs/css!./**/*",
140140
"**/vs/base/{common,browser,node,electron-browser}/**",
141141
"**/vs/base/parts/*/{common,browser,node,electron-browser}/**",
142-
"*" // node modules
142+
"!path" // node modules (except path where we have our own impl)
143143
]
144144
},
145145
{
@@ -148,7 +148,7 @@
148148
"vs/nls",
149149
"**/vs/base/{common,browser,node,electron-main}/**",
150150
"**/vs/base/parts/*/{common,browser,node,electron-main}/**",
151-
"*" // node modules
151+
"!path" // node modules (except path where we have our own impl)
152152
]
153153
},
154154
{
@@ -188,7 +188,7 @@
188188
"**/vs/base/{common,browser,node}/**",
189189
"**/vs/base/parts/*/{common,browser,node}/**",
190190
"**/vs/platform/*/{common,browser,node}/**",
191-
"*" // node modules
191+
"!path" // node modules (except path where we have our own impl)
192192
]
193193
},
194194
{
@@ -199,7 +199,7 @@
199199
"**/vs/base/{common,browser,node}/**",
200200
"**/vs/base/parts/*/{common,browser,node,electron-browser}/**",
201201
"**/vs/platform/*/{common,browser,node,electron-browser}/**",
202-
"*" // node modules
202+
"!path" // node modules (except path where we have our own impl)
203203
]
204204
},
205205
{
@@ -209,7 +209,7 @@
209209
"**/vs/base/{common,browser,node}/**",
210210
"**/vs/base/parts/*/{common,browser,node,electron-browser}/**",
211211
"**/vs/platform/*/{common,browser,node,electron-main}/**",
212-
"*" // node modules
212+
"!path" // node modules (except path where we have our own impl)
213213
]
214214
},
215215
{
@@ -414,7 +414,7 @@
414414
"**/vs/editor/contrib/**", // editor/contrib is equivalent to /browser/ by convention
415415
"**/vs/workbench/{common,browser,node,electron-browser,api}/**",
416416
"**/vs/workbench/services/*/{common,browser,node,electron-browser}/**",
417-
"*" // node modules
417+
"!path" // node modules (except path where we have our own impl)
418418
]
419419
},
420420
{
@@ -429,7 +429,7 @@
429429
"vs/workbench/contrib/files/common/editors/fileEditorInput",
430430
"**/vs/workbench/services/**",
431431
"**/vs/workbench/test/**",
432-
"*" // node modules
432+
"!path" // node modules (except path where we have our own impl)
433433
]
434434
},
435435
{
@@ -486,7 +486,7 @@
486486
"**/vs/workbench/{common,node}/**",
487487
"**/vs/workbench/api/{common,node}/**",
488488
"**/vs/workbench/services/**/{common,node}/**",
489-
"*" // node modules
489+
"!path" // node modules (except path where we have our own impl)
490490
]
491491
},
492492
{
@@ -499,7 +499,7 @@
499499
"**/vs/editor/**",
500500
"**/vs/workbench/{common,browser,node,electron-browser,api}/**",
501501
"**/vs/workbench/services/**/{common,browser,node,electron-browser}/**",
502-
"*" // node modules
502+
"!path" // node modules (except path where we have our own impl)
503503
]
504504
},
505505
{
@@ -564,7 +564,7 @@
564564
"**/vs/base/parts/**/{common,browser,node}/**",
565565
"**/vs/platform/**/{common,browser,node}/**",
566566
"**/vs/code/**/{common,browser,node}/**",
567-
"*" // node modules
567+
"!path" // node modules (except path where we have our own impl)
568568
]
569569
},
570570
{
@@ -576,7 +576,7 @@
576576
"**/vs/base/parts/**/{common,browser,node,electron-browser}/**",
577577
"**/vs/platform/**/{common,browser,node,electron-browser}/**",
578578
"**/vs/code/**/{common,browser,node,electron-browser}/**",
579-
"*" // node modules
579+
"!path" // node modules (except path where we have our own impl)
580580
]
581581
},
582582
{
@@ -587,7 +587,7 @@
587587
"**/vs/base/parts/**/{common,browser,node,electron-main}/**",
588588
"**/vs/platform/**/{common,browser,node,electron-main}/**",
589589
"**/vs/code/**/{common,browser,node,electron-main}/**",
590-
"*" // node modules
590+
"!path" // node modules (except path where we have our own impl)
591591
]
592592
},
593593
{
@@ -600,7 +600,7 @@
600600
"**/vs/workbench/**/{common,node}/**",
601601
"**/vs/server/**",
602602
"**/vs/code/**/{common,node}/**",
603-
"*" // node modules
603+
"!path" // node modules (except path where we have our own impl)
604604
]
605605
},
606606
{

0 commit comments

Comments
 (0)