Command of root task with sequence dependsOn shouldn't execute

alexr00 · alexr00 · commit 43076ce316a3 · 2020-02-21T11:18:20.000+01:00
Fixes microsoft#90352
diff --git a/src/vs/workbench/contrib/tasks/browser/terminalTaskSystem.ts b/src/vs/workbench/contrib/tasks/browser/terminalTaskSystem.ts
@@ -438,6 +438,7 @@ export class TerminalTaskSystem implements ITaskSystem {
 						this._onDidStateChange.fire(TaskEvent.create(TaskEventKind.DependsOnStarted, task));
 						promise = this.executeTask(dependencyTask, resolver, trigger, alreadyResolved);
 					}
+					promises.push(promise);
 					if (task.configurationProperties.dependsOrder === DependsOrder.sequence) {
 						const promiseResult = await promise;
 						if (promiseResult.exitCode === 0) {

Original file line number	Diff line number	Diff line change
`@@ -438,6 +438,7 @@ export class TerminalTaskSystem implements ITaskSystem {`
`438`	`438`	`this._onDidStateChange.fire(TaskEvent.create(TaskEventKind.DependsOnStarted, task));`
`439`	`439`	`promise = this.executeTask(dependencyTask, resolver, trigger, alreadyResolved);`
`440`	`440`	`}`
	`441`	`+ promises.push(promise);`
`441`	`442`	`if (task.configurationProperties.dependsOrder === DependsOrder.sequence) {`
`442`	`443`	`const promiseResult = await promise;`
`443`	`444`	`if (promiseResult.exitCode === 0) {`