Skip to content

Commit 42e938f

Browse files
joaomorenojoaomoreno
committed
git: remove denodeify dependency
1 parent 5690a47 commit 42e938f

7 files changed

Lines changed: 8 additions & 51 deletions

File tree

‎extensions/git/package.json‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -350,7 +350,6 @@
350350
}
351351
},
352352
"dependencies": {
353-
"denodeify": "^1.2.1",
354353
"vscode-nls": "^2.0.1"
355354
}
356355
}

‎extensions/git/src/git.ts‎

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,13 @@ import * as fs from 'fs';
99
import * as path from 'path';
1010
import * as os from 'os';
1111
import * as cp from 'child_process';
12-
import * as denodeify from 'denodeify';
13-
import { assign, uniqBy, groupBy, IDisposable, toDisposable, dispose } from './util';
12+
import { assign, uniqBy, groupBy, denodeify, IDisposable, toDisposable, dispose } from './util';
1413
import { EventEmitter, Event } from 'vscode';
1514
import * as nls from 'vscode-nls';
1615

1716
const localize = nls.loadMessageBundle();
18-
const readdir = denodeify(fs.readdir);
19-
const readfile = denodeify<string, string, string>(fs.readFile);
17+
const readdir = denodeify<string[]>(fs.readdir);
18+
const readfile = denodeify<string>(fs.readFile);
2019

2120
export interface IGit {
2221
path: string;

‎extensions/git/src/typings.json‎

Lines changed: 0 additions & 5 deletions
This file was deleted.

‎extensions/git/src/typings/globals/denodeify/index.d.ts‎

Lines changed: 0 additions & 31 deletions
This file was deleted.

‎extensions/git/src/typings/globals/denodeify/typings.json‎

Lines changed: 0 additions & 8 deletions
This file was deleted.

‎extensions/git/src/typings/index.d.ts‎

Lines changed: 0 additions & 1 deletion
This file was deleted.

‎extensions/git/src/util.ts‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,4 +88,8 @@ export function groupBy<T>(arr: T[], fn: (el: T) => string): { [key: string]: T[
8888
result[key] = [...(result[key] || []), el];
8989
return result;
9090
}, Object.create(null));
91-
}
91+
}
92+
93+
export function denodeify<R>(fn: Function): (...args) => Promise<R> {
94+
return (...args) => new Promise((c, e) => fn(...args, (err, r) => err ? e(err) : c(r)));
95+
}

0 commit comments

Comments
 (0)