start crash reporter properly given directory argument (refs microsoft#98122)

Benjamin Pasero · Benjamin Pasero · commit 42ae88fd51ff · 2020-05-27T11:01:11.000+02:00
diff --git a/src/vs/workbench/electron-browser/window.ts b/src/vs/workbench/electron-browser/window.ts
@@ -432,16 +432,16 @@ export class NativeWindow extends Disposable {
 			const companyName = product.crashReporter?.companyName || 'Microsoft';
 			const productName = product.crashReporter?.productName || product.nameShort;
 
-			// With appCenter enabled, crashes will be uploaded
-			if (product.appCenter) {
-				this.setupCrashReporter(companyName, productName, product.appCenter, undefined);
-			}
-
 			// With a provided crash reporter directory, crashes
 			// will be stored only locally in that folder
-			else if (this.environmentService.crashReporterDirectory) {
+			if (this.environmentService.crashReporterDirectory) {
 				this.setupCrashReporter(companyName, productName, undefined, this.environmentService.crashReporterDirectory);
 			}
+
+			// With appCenter enabled, crashes will be uploaded
+			else if (product.appCenter) {
+				this.setupCrashReporter(companyName, productName, product.appCenter, undefined);
+			}
 		}
 	}
 
