debt - platform#setImmediate should be a micro task on all platforms

jrieken · jrieken · commit 429373382554 · 2019-09-02T11:41:03.000+02:00
diff --git a/src/vs/base/common/platform.ts b/src/vs/base/common/platform.ts
@@ -156,20 +156,21 @@ export const translationsConfigFile = _translationsConfigFile;
 const _globals = (typeof self === 'object' ? self : typeof global === 'object' ? global : {} as any);
 export const globals: any = _globals;
 
-let _setImmediate: ((callback: (...args: any[]) => void) => number) | null = null;
-export function setImmediate(callback: (...args: any[]) => void): number {
-	if (_setImmediate === null) {
-		if (globals.setImmediate) {
-			_setImmediate = globals.setImmediate.bind(globals);
-		} else if (typeof process !== 'undefined' && typeof process.nextTick === 'function') {
-			_setImmediate = process.nextTick.bind(process);
-		} else {
-			_setImmediate = globals.setTimeout.bind(globals);
-		}
-	}
-	return _setImmediate!(callback);
+interface ISetImmediate {
+	(callback: (...args: any[]) => void): void;
 }
 
+export const setImmediate: ISetImmediate = (function defineSetImmediate() {
+	if (globals.setImmediate) {
+		return globals.setImmediate.bind(globals);
+	}
+	if (typeof process !== 'undefined' && typeof process.nextTick === 'function') {
+		return process.nextTick.bind(process);
+	}
+	const _promise = Promise.resolve();
+	return (callback: (...args: any[]) => void) => _promise.then(callback);
+})();
+
 export const enum OperatingSystem {
 	Windows = 1,
 	Macintosh = 2,
diff --git a/src/vs/base/common/process.ts b/src/vs/base/common/process.ts
@@ -10,15 +10,15 @@ interface IProcess {
 	env: IProcessEnvironment;
 
 	cwd(): string;
-	nextTick(callback: (...args: any[]) => void): number;
+	nextTick(callback: (...args: any[]) => void): void;
 }
 
 declare const process: IProcess;
 const safeProcess: IProcess = (typeof process === 'undefined') ? {
 	cwd(): string { return '/'; },
 	env: Object.create(null),
 	get platform(): string { return isWindows ? 'win32' : isMacintosh ? 'darwin' : 'linux'; },
-	nextTick(callback: (...args: any[]) => void): number { return setImmediate(callback); }
+	nextTick(callback: (...args: any[]) => void): void { return setImmediate(callback); }
 } : process;
 
 export const cwd = safeProcess.cwd;
