Skip to content

Commit 41466a2

Browse files
author
Benjamin Pasero
committed
debt - declare more fs provider capabilities
1 parent 5de0162 commit 41466a2

5 files changed

Lines changed: 8 additions & 20 deletions

File tree

‎src/vs/base/common/errors.ts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,6 @@ export function getErrorMessage(err: any): string {
195195
return String(err);
196196
}
197197

198-
199198
export class NotImplementedError extends Error {
200199
constructor(message?: string) {
201200
super('NotImplemented');

‎src/vs/workbench/api/browser/mainThreadFileSystem.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
import { Emitter, Event } from 'vs/base/common/event';
77
import { IDisposable, dispose, toDisposable } from 'vs/base/common/lifecycle';
88
import { URI, UriComponents } from 'vs/base/common/uri';
9-
import { FileWriteOptions, FileSystemProviderCapabilities, IFileChange, IFileService, IFileSystemProvider, IStat, IWatchOptions, FileType, FileOverwriteOptions, FileDeleteOptions, FileOpenOptions, IFileStat, FileOperationError, FileOperationResult, FileSystemProviderErrorCode } from 'vs/platform/files/common/files';
9+
import { FileWriteOptions, FileSystemProviderCapabilities, IFileChange, IFileService, IStat, IWatchOptions, FileType, FileOverwriteOptions, FileDeleteOptions, FileOpenOptions, IFileStat, FileOperationError, FileOperationResult, FileSystemProviderErrorCode, IFileSystemProviderWithOpenReadWriteCloseCapability, IFileSystemProviderWithFileReadWriteCapability, IFileSystemProviderWithFileFolderCopyCapability } from 'vs/platform/files/common/files';
1010
import { extHostNamedCustomer } from 'vs/workbench/api/common/extHostCustomers';
1111
import { ExtHostContext, ExtHostFileSystemShape, IExtHostContext, IFileChangeDto, MainContext, MainThreadFileSystemShape } from '../common/extHost.protocol';
1212
import { VSBuffer } from 'vs/base/common/buffer';
@@ -121,7 +121,7 @@ export class MainThreadFileSystem implements MainThreadFileSystemShape {
121121
}
122122
}
123123

124-
class RemoteFileSystemProvider implements IFileSystemProvider {
124+
class RemoteFileSystemProvider implements IFileSystemProviderWithFileReadWriteCapability, IFileSystemProviderWithOpenReadWriteCloseCapability, IFileSystemProviderWithFileFolderCopyCapability {
125125

126126
private readonly _onDidChange = new Emitter<readonly IFileChange[]>();
127127
private readonly _registration: IDisposable;

‎src/vs/workbench/contrib/url/common/trustedDomainsFileSystemProvider.ts‎

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -7,17 +7,7 @@ import { Event } from 'vs/base/common/event';
77
import { parse } from 'vs/base/common/json';
88
import { IDisposable } from 'vs/base/common/lifecycle';
99
import { URI } from 'vs/base/common/uri';
10-
import {
11-
FileDeleteOptions,
12-
FileOverwriteOptions,
13-
FileSystemProviderCapabilities,
14-
FileType,
15-
FileWriteOptions,
16-
IFileService,
17-
IFileSystemProvider,
18-
IStat,
19-
IWatchOptions
20-
} from 'vs/platform/files/common/files';
10+
import { FileDeleteOptions, FileOverwriteOptions, FileSystemProviderCapabilities, FileType, FileWriteOptions, IFileService, IStat, IWatchOptions, IFileSystemProviderWithFileReadWriteCapability } from 'vs/platform/files/common/files';
2111
import { IStorageService, StorageScope } from 'vs/platform/storage/common/storage';
2212
import { IWorkbenchContribution } from 'vs/workbench/common/contributions';
2313
import { VSBuffer } from 'vs/base/common/buffer';
@@ -75,7 +65,7 @@ function computeTrustedDomainContent(defaultTrustedDomains: string[], trustedDom
7565
return content;
7666
}
7767

78-
export class TrustedDomainsFileSystemProvider implements IFileSystemProvider, IWorkbenchContribution {
68+
export class TrustedDomainsFileSystemProvider implements IFileSystemProviderWithFileReadWriteCapability, IWorkbenchContribution {
7969
readonly capabilities = FileSystemProviderCapabilities.FileReadWrite;
8070

8171
readonly onDidChangeCapabilities = Event.None;

‎src/vs/workbench/services/extensions/browser/webWorkerFileSystemProvider.ts‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,13 @@
33
* Licensed under the MIT License. See License.txt in the project root for license information.
44
*--------------------------------------------------------------------------------------------*/
55

6-
import { IFileSystemProvider, FileSystemProviderCapabilities, IStat, FileType, FileDeleteOptions, FileOverwriteOptions, FileWriteOptions, FileSystemProviderError, FileSystemProviderErrorCode } from 'vs/platform/files/common/files';
7-
6+
import { FileSystemProviderCapabilities, IStat, FileType, FileDeleteOptions, FileOverwriteOptions, FileWriteOptions, FileSystemProviderError, FileSystemProviderErrorCode, IFileSystemProviderWithFileReadWriteCapability } from 'vs/platform/files/common/files';
87
import { Event } from 'vs/base/common/event';
98
import { IDisposable, Disposable } from 'vs/base/common/lifecycle';
109
import { URI } from 'vs/base/common/uri';
1110
import { NotImplementedError } from 'vs/base/common/errors';
1211

13-
export class FetchFileSystemProvider implements IFileSystemProvider {
12+
export class FetchFileSystemProvider implements IFileSystemProviderWithFileReadWriteCapability {
1413

1514
readonly capabilities = FileSystemProviderCapabilities.Readonly + FileSystemProviderCapabilities.FileReadWrite + FileSystemProviderCapabilities.PathCaseSensitive;
1615
readonly onDidChangeCapabilities = Event.None;

‎src/vs/workbench/services/userData/common/inMemoryUserDataProvider.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
import { Event, Emitter } from 'vs/base/common/event';
77
import { Disposable, IDisposable } from 'vs/base/common/lifecycle';
88
import * as resources from 'vs/base/common/resources';
9-
import { FileChangeType, IFileSystemProvider, FileType, IWatchOptions, IStat, FileSystemProviderErrorCode, FileSystemProviderError, FileWriteOptions, IFileChange, FileDeleteOptions, FileSystemProviderCapabilities, FileOverwriteOptions } from 'vs/platform/files/common/files';
9+
import { FileChangeType, FileType, IWatchOptions, IStat, FileSystemProviderErrorCode, FileSystemProviderError, FileWriteOptions, IFileChange, FileDeleteOptions, FileSystemProviderCapabilities, FileOverwriteOptions, IFileSystemProviderWithFileReadWriteCapability } from 'vs/platform/files/common/files';
1010
import { URI } from 'vs/base/common/uri';
1111

1212
class File implements IStat {
@@ -50,7 +50,7 @@ class Directory implements IStat {
5050

5151
export type Entry = File | Directory;
5252

53-
export class InMemoryFileSystemProvider extends Disposable implements IFileSystemProvider {
53+
export class InMemoryFileSystemProvider extends Disposable implements IFileSystemProviderWithFileReadWriteCapability {
5454

5555
readonly capabilities: FileSystemProviderCapabilities = FileSystemProviderCapabilities.FileReadWrite;
5656
readonly onDidChangeCapabilities: Event<void> = Event.None;

0 commit comments

Comments
 (0)