remove casting bufferlogservice

sandy081 · sandy081 · commit 3fcf9d7eae7d · 2019-09-26T11:01:40.000+02:00
diff --git a/src/vs/platform/log/common/bufferLog.ts b/src/vs/platform/log/common/bufferLog.ts
@@ -7,7 +7,7 @@ import { ILogService, LogLevel, AbstractLogService, DEFAULT_LOG_LEVEL } from 'vs
 
 interface ILog {
 	level: LogLevel;
-	args: IArguments;
+	args: any[];
 }
 
 function getLogFunction(logger: ILogService, level: LogLevel): Function {
@@ -49,7 +49,7 @@ export class BufferLogService extends AbstractLogService implements ILogService
 		this.buffer = [];
 	}
 
-	private _log(level: LogLevel, args: IArguments): void {
+	private _log(level: LogLevel, ...args: any[]): void {
 		if (this._logger) {
 			const fn = getLogFunction(this._logger, level);
 			fn.apply(this._logger, args);
@@ -58,28 +58,28 @@ export class BufferLogService extends AbstractLogService implements ILogService
 		}
 	}
 
-	trace(): void {
-		this._log(LogLevel.Trace, arguments);
+	trace(message: string, ...args: any[]): void {
+		this._log(LogLevel.Trace, message, ...args);
 	}
 
-	debug(): void {
-		this._log(LogLevel.Debug, arguments);
+	debug(message: string, ...args: any[]): void {
+		this._log(LogLevel.Debug, message, ...args);
 	}
 
-	info(): void {
-		this._log(LogLevel.Info, arguments);
+	info(message: string, ...args: any[]): void {
+		this._log(LogLevel.Info, message, ...args);
 	}
 
-	warn(): void {
-		this._log(LogLevel.Warning, arguments);
+	warn(message: string, ...args: any[]): void {
+		this._log(LogLevel.Warning, message, ...args);
 	}
 
-	error(): void {
-		this._log(LogLevel.Error, arguments);
+	error(message: string | Error, ...args: any[]): void {
+		this._log(LogLevel.Error, message, ...args);
 	}
 
-	critical(): void {
-		this._log(LogLevel.Critical, arguments);
+	critical(message: string | Error, ...args: any[]): void {
+		this._log(LogLevel.Critical, message, ...args);
 	}
 
 	dispose(): void {
diff --git a/src/vs/workbench/browser/web.main.ts b/src/vs/workbench/browser/web.main.ts
@@ -216,8 +216,8 @@ class BrowserMain extends Disposable {
 
 				fileService.registerProvider(logsPath.scheme, indexedDBLogProvider);
 			} catch (error) {
-				(<ILogService>logService).info('Error while creating indexedDB log provider. Falling back to in-memory log provider.');
-				(<ILogService>logService).error(error);
+				logService.info('Error while creating indexedDB log provider. Falling back to in-memory log provider.');
+				logService.error(error);
 
 				fileService.registerProvider(logsPath.scheme, new InMemoryLogProvider(logsPath.scheme));
 			}

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@ import { ILogService, LogLevel, AbstractLogService, DEFAULT_LOG_LEVEL } from 'vs`
`7`	`7`
`8`	`8`	`interface ILog {`
`9`	`9`	`level: LogLevel;`
`10`		`- args: IArguments;`
	`10`	`+ args: any[];`
`11`	`11`	`}`
`12`	`12`
`13`	`13`	`function getLogFunction(logger: ILogService, level: LogLevel): Function {`
`@@ -49,7 +49,7 @@ export class BufferLogService extends AbstractLogService implements ILogService`
`49`	`49`	`this.buffer = [];`
`50`	`50`	`}`
`51`	`51`
`52`		`- private _log(level: LogLevel, args: IArguments): void {`
	`52`	`+ private _log(level: LogLevel, ...args: any[]): void {`
`53`	`53`	`if (this._logger) {`
`54`	`54`	`const fn = getLogFunction(this._logger, level);`
`55`	`55`	`fn.apply(this._logger, args);`
`@@ -58,28 +58,28 @@ export class BufferLogService extends AbstractLogService implements ILogService`
`58`	`58`	`}`
`59`	`59`	`}`
`60`	`60`
`61`		`- trace(): void {`
`62`		`- this._log(LogLevel.Trace, arguments);`
	`61`	`+ trace(message: string, ...args: any[]): void {`
	`62`	`+ this._log(LogLevel.Trace, message, ...args);`
`63`	`63`	`}`
`64`	`64`
`65`		`- debug(): void {`
`66`		`- this._log(LogLevel.Debug, arguments);`
	`65`	`+ debug(message: string, ...args: any[]): void {`
	`66`	`+ this._log(LogLevel.Debug, message, ...args);`
`67`	`67`	`}`
`68`	`68`
`69`		`- info(): void {`
`70`		`- this._log(LogLevel.Info, arguments);`
	`69`	`+ info(message: string, ...args: any[]): void {`
	`70`	`+ this._log(LogLevel.Info, message, ...args);`
`71`	`71`	`}`
`72`	`72`
`73`		`- warn(): void {`
`74`		`- this._log(LogLevel.Warning, arguments);`
	`73`	`+ warn(message: string, ...args: any[]): void {`
	`74`	`+ this._log(LogLevel.Warning, message, ...args);`
`75`	`75`	`}`
`76`	`76`
`77`		`- error(): void {`
`78`		`- this._log(LogLevel.Error, arguments);`
	`77`	`+ error(message: string \| Error, ...args: any[]): void {`
	`78`	`+ this._log(LogLevel.Error, message, ...args);`
`79`	`79`	`}`
`80`	`80`
`81`		`- critical(): void {`
`82`		`- this._log(LogLevel.Critical, arguments);`
	`81`	`+ critical(message: string \| Error, ...args: any[]): void {`
	`82`	`+ this._log(LogLevel.Critical, message, ...args);`
`83`	`83`	`}`
`84`	`84`
`85`	`85`	`dispose(): void {`
Original file line number	Diff line number	Diff line change
`@@ -216,8 +216,8 @@ class BrowserMain extends Disposable {`
`216`	`216`
`217`	`217`	`fileService.registerProvider(logsPath.scheme, indexedDBLogProvider);`
`218`	`218`	`} catch (error) {`
`219`		`- (<ILogService>logService).info('Error while creating indexedDB log provider. Falling back to in-memory log provider.');`
`220`		`- (<ILogService>logService).error(error);`
	`219`	`+ logService.info('Error while creating indexedDB log provider. Falling back to in-memory log provider.');`
	`220`	`+ logService.error(error);`
`221`	`221`
`222`	`222`	`fileService.registerProvider(logsPath.scheme, new InMemoryLogProvider(logsPath.scheme));`
`223`	`223`	`}`