Dispose data listener before disposing terminal

Tyriar · Tyriar · commit 3d7745d6fc89 · 2020-04-23T07:29:47.000-07:00
Fixes microsoft#95945
diff --git a/extensions/vscode-api-tests/src/singlefolder-tests/terminal.test.ts b/extensions/vscode-api-tests/src/singlefolder-tests/terminal.test.ts
@@ -45,7 +45,7 @@ import { doesNotThrow, equal, ok, deepEqual, throws } from 'assert';
 					return;
 				}
 				let data = '';
-				disposables.push(window.onDidWriteTerminalData(e => {
+				const dataDisposable = window.onDidWriteTerminalData(e => {
 					try {
 						equal(terminal, e.terminal);
 					} catch (e) {
@@ -54,10 +54,12 @@ import { doesNotThrow, equal, ok, deepEqual, throws } from 'assert';
 					}
 					data += e.data;
 					if (data.indexOf(expected) !== 0) {
+						dataDisposable.dispose();
 						terminal.dispose();
 						disposables.push(window.onDidCloseTerminal(() => done()));
 					}
-				}));
+				});
+				disposables.push(dataDisposable);
 			}));
 			// Use a single character to avoid winpty/conpty issues with injected sequences
 			const expected = '`';
