set role: 'code' on the monaco-editor

isidorn · isidorn · commit 3d4047453754 · 2020-04-16T10:01:13.000+02:00
fixes microsoft#93438
diff --git a/src/vs/editor/browser/view/viewImpl.ts b/src/vs/editor/browser/view/viewImpl.ts
@@ -136,6 +136,8 @@ export class View extends ViewEventHandler {
 
 		this.domNode = createFastDomNode(document.createElement('div'));
 		this.domNode.setClassName(this.getEditorClassName());
+		// Set role 'code' for better screen reader support https://github.com/microsoft/vscode/issues/93438
+		this.domNode.setAttribute('role', 'code');
 
 		this.overflowGuardContainer = createFastDomNode(document.createElement('div'));
 		PartFingerprints.write(this.overflowGuardContainer, PartFingerprint.OverflowGuard);
diff --git a/src/vs/workbench/browser/parts/editor/editorControl.ts b/src/vs/workbench/browser/parts/editor/editorControl.ts
@@ -113,7 +113,6 @@ export class EditorControl extends Disposable {
 			const editorPaneContainer = document.createElement('div');
 			addClass(editorPaneContainer, 'editor-instance');
 			editorPaneContainer.setAttribute('data-editor-id', descriptor.getId());
-			editorPaneContainer.setAttribute('role', 'code');
 
 			editorPane.create(editorPaneContainer);
 		}

Original file line number	Diff line number	Diff line change
`@@ -113,7 +113,6 @@ export class EditorControl extends Disposable {`
`113`	`113`	`const editorPaneContainer = document.createElement('div');`
`114`	`114`	`addClass(editorPaneContainer, 'editor-instance');`
`115`	`115`	`editorPaneContainer.setAttribute('data-editor-id', descriptor.getId());`
`116`		`- editorPaneContainer.setAttribute('role', 'code');`
`117`	`116`
`118`	`117`	`editorPane.create(editorPaneContainer);`
`119`	`118`	`}`