web - stay in standalone mode when opening new windows from standalone

Benjamin Pasero · Benjamin Pasero · commit 3bb34b269a89 · 2019-10-18T08:57:31.000+02:00
diff --git a/src/vs/code/browser/workbench/workbench.ts b/src/vs/code/browser/workbench/workbench.ts
@@ -11,6 +11,7 @@ import { Disposable } from 'vs/base/common/lifecycle';
 import { request } from 'vs/base/parts/request/browser/request';
 import { isFolderToOpen, isWorkspaceToOpen } from 'vs/platform/windows/common/windows';
 import { isEqual } from 'vs/base/common/resources';
+import { isStandalone } from 'vs/base/browser/browser';
 
 interface ICredential {
 	service: string;
@@ -228,7 +229,11 @@ class WorkspaceProvider implements IWorkspaceProvider {
 			if (options && options.reuse) {
 				window.location.href = targetHref;
 			} else {
-				window.open(targetHref);
+				if (isStandalone) {
+					window.open(targetHref, '_blank', 'toolbar=no'); // ensures to open another 'standalone' window!
+				} else {
+					window.open(targetHref);
+				}
 			}
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -11,6 +11,7 @@ import { Disposable } from 'vs/base/common/lifecycle';`
`11`	`11`	`import { request } from 'vs/base/parts/request/browser/request';`
`12`	`12`	`import { isFolderToOpen, isWorkspaceToOpen } from 'vs/platform/windows/common/windows';`
`13`	`13`	`import { isEqual } from 'vs/base/common/resources';`
	`14`	`+import { isStandalone } from 'vs/base/browser/browser';`
`14`	`15`
`15`	`16`	`interface ICredential {`
`16`	`17`	`service: string;`
`@@ -228,7 +229,11 @@ class WorkspaceProvider implements IWorkspaceProvider {`
`228`	`229`	`if (options && options.reuse) {`
`229`	`230`	`window.location.href = targetHref;`
`230`	`231`	`} else {`
`231`		`- window.open(targetHref);`
	`232`	`+ if (isStandalone) {`
	`233`	`+ window.open(targetHref, '_blank', 'toolbar=no'); // ensures to open another 'standalone' window!`
	`234`	`+ } else {`
	`235`	`+ window.open(targetHref);`
	`236`	`+ }`
`232`	`237`	`}`
`233`	`238`	`}`
`234`	`239`	`}`