fixes microsoft#35216

joaomoreno · joaomoreno · commit 3b76085a6c8d · 2017-09-28T11:51:40.000+02:00
diff --git a/extensions/git/src/autofetch.ts b/extensions/git/src/autofetch.ts
@@ -5,16 +5,23 @@
 
 'use strict';
 
-import { workspace, Disposable } from 'vscode';
+import { workspace, Disposable, EventEmitter } from 'vscode';
 import { GitErrorCodes } from './git';
 import { Repository } from './repository';
-import { throttle } from './decorators';
+import { eventToPromise, filterEvent } from './util';
 
 export class AutoFetcher {
 
 	private static Period = 3 * 60 * 1000 /* three minutes */;
+
+	private _onDidChange = new EventEmitter<boolean>();
+	private onDidChange = this._onDidChange.event;
+
+	private _enabled: boolean = false;
+	get enabled(): boolean { return this._enabled; }
+	set enabled(enabled: boolean) { this._enabled = enabled; this._onDidChange.fire(enabled); }
+
 	private disposables: Disposable[] = [];
-	private timer: NodeJS.Timer;
 
 	constructor(private repository: Repository) {
 		workspace.onDidChangeConfiguration(this.onConfiguration, this, this.disposables);
@@ -32,26 +39,41 @@ export class AutoFetcher {
 	}
 
 	enable(): void {
-		if (this.timer) {
+		if (this.enabled) {
 			return;
 		}
 
-		this.fetch();
-		this.timer = setInterval(() => this.fetch(), AutoFetcher.Period);
+		this.enabled = true;
+		this.run();
 	}
 
 	disable(): void {
-		clearInterval(this.timer);
+		this.enabled = false;
 	}
 
-	@throttle
-	private async fetch(): Promise<void> {
-		try {
-			await this.repository.fetch();
-		} catch (err) {
-			if (err.gitErrorCode === GitErrorCodes.AuthenticationFailed) {
-				this.disable();
+	private async run(): Promise<void> {
+		while (this.enabled) {
+			await this.repository.whenIdleAndFocused();
+
+			if (!this.enabled) {
+				return;
 			}
+
+			try {
+				await this.repository.fetch();
+			} catch (err) {
+				if (err.gitErrorCode === GitErrorCodes.AuthenticationFailed) {
+					this.disable();
+				}
+			}
+
+			if (!this.enabled) {
+				return;
+			}
+
+			const timeout = new Promise(c => setTimeout(c, AutoFetcher.Period));
+			const whenDisabled = eventToPromise(filterEvent(this.onDidChange, enabled => !enabled));
+			await Promise.race([timeout, whenDisabled]);
 		}
 	}
 
diff --git a/extensions/git/src/contentProvider.ts b/extensions/git/src/contentProvider.ts
@@ -6,9 +6,10 @@
 'use strict';
 
 import { workspace, Uri, Disposable, Event, EventEmitter, window } from 'vscode';
-import { debounce } from './decorators';
+import { debounce, throttle } from './decorators';
 import { fromGitUri } from './uri';
 import { Model, ModelChangeEvent } from './model';
+import { filterEvent, eventToPromise } from './util';
 
 interface CacheRow {
 	uri: Uri;
@@ -50,7 +51,13 @@ export class GitContentProvider {
 		this.fireChangeEvents();
 	}
 
-	private fireChangeEvents(): void {
+	@throttle
+	private async fireChangeEvents(): Promise<void> {
+		if (!window.state.focused) {
+			const onDidFocusWindow = filterEvent(window.onDidChangeWindowState, e => e.focused);
+			await eventToPromise(onDidFocusWindow);
+		}
+
 		Object.keys(this.cache).forEach(key => {
 			const uri = this.cache[key].uri;
 			const fsPath = uri.fsPath;
diff --git a/extensions/git/src/repository.ts b/extensions/git/src/repository.ts
@@ -816,7 +816,7 @@ export class Repository implements Disposable {
 		await timeout(5000);
 	}
 
-	private async whenIdleAndFocused(): Promise<void> {
+	async whenIdleAndFocused(): Promise<void> {
 		while (true) {
 			if (!this.operations.isIdle()) {
 				await eventToPromise(this.onDidRunOperation);

Original file line number	Diff line number	Diff line change
`@@ -816,7 +816,7 @@ export class Repository implements Disposable {`
`816`	`816`	`await timeout(5000);`
`817`	`817`	`}`
`818`	`818`
`819`		`- private async whenIdleAndFocused(): Promise<void> {`
	`819`	`+ async whenIdleAndFocused(): Promise<void> {`
`820`	`820`	`while (true) {`
`821`	`821`	`if (!this.operations.isIdle()) {`
`822`	`822`	`await eventToPromise(this.onDidRunOperation);`