Skip to content

Commit 38af41b

Browse files
ramya-rao-aramya-rao-a
committed
Update GDPR annotations
1 parent 87bcab7 commit 38af41b

17 files changed

Lines changed: 42 additions & 42 deletions

File tree

‎src/vs/platform/extensionManagement/common/extensionManagementUtil.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ export function getLocalExtensionTelemetryData(extension: ILocalExtension): any
8585
"publisherId": { "classification": "PublicNonPersonalData", "purpose": "FeatureInsight" },
8686
"publisherName": { "classification": "PublicNonPersonalData", "purpose": "FeatureInsight" },
8787
"publisherDisplayName": { "classification": "PublicPersonalData", "purpose": "FeatureInsight" },
88-
"dependencies": { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
88+
"dependencies": { "classification": "SystemMetaData", "purpose": "FeatureInsight", "isMeasurement": true },
8989
"${include}": [
9090
"${GalleryExtensionTelemetryData2}"
9191
]

‎src/vs/platform/extensionManagement/node/extensionGalleryService.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -303,7 +303,7 @@ function toExtension(galleryExtension: IRawGalleryExtension, extensionsGalleryUr
303303
},
304304
/* __GDPR__FRAGMENT__
305305
"GalleryExtensionTelemetryData2" : {
306-
"index" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
306+
"index" : { "classification": "SystemMetaData", "purpose": "FeatureInsight", "isMeasurement": true },
307307
"searchText": { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
308308
"querySource": { "classification": "SystemMetaData", "purpose": "FeatureInsight" }
309309
}

‎src/vs/platform/telemetry/browser/errorTelemetry.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -149,8 +149,8 @@ export default class ErrorTelemetry {
149149
"name": { "classification": "CallstackOrException", "purpose": "PerformanceAndHealth" },
150150
"stack": { "classification": "CallstackOrException", "purpose": "PerformanceAndHealth" },
151151
"id": { "classification": "CallstackOrException", "purpose": "PerformanceAndHealth" },
152-
"line": { "classification": "CallstackOrException", "purpose": "PerformanceAndHealth" },
153-
"column": { "classification": "CallstackOrException", "purpose": "PerformanceAndHealth" }
152+
"line": { "classification": "CallstackOrException", "purpose": "PerformanceAndHealth", "isMeasurement": true },
153+
"column": { "classification": "CallstackOrException", "purpose": "PerformanceAndHealth", "isMeasurement": true }
154154
}
155155
*/
156156
// __GDPR__TODO__ what's the complete set of properties?

‎src/vs/platform/telemetry/node/workbenchCommonProperties.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ export function resolveWorkbenchCommonProperties(storageService: IStorageService
2626
result['common.lastSessionDate'] = lastSessionDate;
2727
// __GDPR__COMMON__ "common.isNewSession" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" }
2828
result['common.isNewSession'] = !lastSessionDate ? '1' : '0';
29-
// __GDPR__COMMON__ "common.instanceId" : { "classification": "EndUserPseudonymizedInformation", "purpose": "FeatureInsight" }
29+
// __GDPR__COMMON__ "common.instanceId" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" }
3030
result['common.instanceId'] = getOrCreateInstanceId(storageService);
3131

3232
return result;

‎src/vs/workbench/api/electron-browser/mainThreadTelemetry.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ export class MainThreadTelemetry implements MainThreadTelemetryShape {
2525
}
2626

2727
$publicLog(eventName: string, data: any = Object.create(null)): void {
28-
// __GDPR__COMMON__ "pluginHostTelemetry" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" }
28+
// __GDPR__COMMON__ "pluginHostTelemetry" : { "classification": "SystemMetaData", "purpose": "FeatureInsight", "isMeasurement": true }
2929
data[MainThreadTelemetry._name] = true;
3030
this._telemetryService.publicLog(eventName, data);
3131
}

‎src/vs/workbench/browser/parts/editor/editorGroupsControl.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1593,8 +1593,8 @@ export class EditorGroupsControl extends Themable implements IEditorGroupsContro
15931593
// TODO@Ben remove me after a while
15941594
/* __GDPR__
15951595
"editorGroupMoved" : {
1596-
"source" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
1597-
"to": { "classification": "SystemMetaData", "purpose": "FeatureInsight" }
1596+
"source" : { "classification": "SystemMetaData", "purpose": "FeatureInsight", "isMeasurement": true },
1597+
"to": { "classification": "SystemMetaData", "purpose": "FeatureInsight", "isMeasurement": true }
15981598
}
15991599
*/
16001600
this.telemetryService.publicLog('editorGroupMoved', { source: position, to: moveTo });

‎src/vs/workbench/parts/cache/node/nodeCachedDataManager.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,9 @@ export class NodeCachedDataManager implements IWorkbenchContribution {
4949
// log summary
5050
/* __GDPR__
5151
"cachedDataInfo" : {
52-
"didRequestCachedData" : { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" },
53-
"didRejectCachedData": { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" },
54-
"didProduceCachedData": { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" }
52+
"didRequestCachedData" : { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth", "isMeasurement": true },
53+
"didRejectCachedData": { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth", "isMeasurement": true },
54+
"didProduceCachedData": { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth", "isMeasurement": true }
5555
}
5656
*/
5757
this._telemetryService.publicLog('cachedDataInfo', {

‎src/vs/workbench/parts/debug/electron-browser/debugService.ts‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -932,12 +932,12 @@ export class DebugService implements debug.IDebugService {
932932
/* __GDPR__
933933
"debugSessionStart" : {
934934
"type": { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
935-
"breakpointCount": { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
935+
"breakpointCount": { "classification": "SystemMetaData", "purpose": "FeatureInsight", "isMeasurement": true },
936936
"exceptionBreakpoints": { "classification": "CustomerContent", "purpose": "FeatureInsight" },
937-
"watchExpressionsCount": { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
937+
"watchExpressionsCount": { "classification": "SystemMetaData", "purpose": "FeatureInsight", "isMeasurement": true },
938938
"extensionName": { "classification": "PublicPersonalData", "purpose": "FeatureInsight" },
939-
"isBuiltin": { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
940-
"launchJsonExists": { "classification": "SystemMetaData", "purpose": "FeatureInsight" }
939+
"isBuiltin": { "classification": "SystemMetaData", "purpose": "FeatureInsight", "isMeasurement": true},
940+
"launchJsonExists": { "classification": "SystemMetaData", "purpose": "FeatureInsight", "isMeasurement": true }
941941
}
942942
*/
943943
return this.telemetryService.publicLog('debugSessionStart', {
@@ -1129,10 +1129,10 @@ export class DebugService implements debug.IDebugService {
11291129
/* __GDPR__
11301130
"debugSessionStop" : {
11311131
"type" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
1132-
"success": { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
1133-
"sessionLengthInSeconds": { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
1134-
"breakpointCount": { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
1135-
"watchExpressionsCount": { "classification": "SystemMetaData", "purpose": "FeatureInsight" }
1132+
"success": { "classification": "SystemMetaData", "purpose": "FeatureInsight", "isMeasurement": true },
1133+
"sessionLengthInSeconds": { "classification": "SystemMetaData", "purpose": "FeatureInsight", "isMeasurement": true },
1134+
"breakpointCount": { "classification": "SystemMetaData", "purpose": "FeatureInsight", "isMeasurement": true },
1135+
"watchExpressionsCount": { "classification": "SystemMetaData", "purpose": "FeatureInsight", "isMeasurement": true }
11361136
}
11371137
*/
11381138
this.telemetryService.publicLog('debugSessionStop', {

‎src/vs/workbench/parts/extensions/electron-browser/extensionEditor.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -305,7 +305,7 @@ export class ExtensionEditor extends BaseEditor {
305305

306306
/* __GDPR__
307307
"extensionGallery:openExtension" : {
308-
"recommendationReason": { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
308+
"recommendationReason": { "classification": "SystemMetaData", "purpose": "FeatureInsight", "isMeasurement": true },
309309
"${include}": [
310310
"${GalleryExtensionTelemetryData}"
311311
]

‎src/vs/workbench/parts/extensions/electron-browser/extensionTipsService.ts‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -580,7 +580,7 @@ export class ExtensionTipsService extends Disposable implements IExtensionTipsSe
580580
/* __GDPR__
581581
"fileExtensionSuggestion:popup" : {
582582
"userReaction" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
583-
"extensionId": { "classification": "PublicNonPersonalData", "purpose": "FeatureInsight" }
583+
"fileExtension": { "classification": "PublicNonPersonalData", "purpose": "FeatureInsight" }
584584
}
585585
*/
586586
this.telemetryService.publicLog('fileExtensionSuggestion:popup', { userReaction: 'ok', fileExtension: fileExtension });
@@ -601,7 +601,7 @@ export class ExtensionTipsService extends Disposable implements IExtensionTipsSe
601601
/* __GDPR__
602602
"fileExtensionSuggestion:popup" : {
603603
"userReaction" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
604-
"extensionId": { "classification": "PublicNonPersonalData", "purpose": "FeatureInsight" }
604+
"fileExtension": { "classification": "PublicNonPersonalData", "purpose": "FeatureInsight" }
605605
}
606606
*/
607607
this.telemetryService.publicLog('fileExtensionSuggestion:popup', { userReaction: 'neverShowAgain', fileExtension: fileExtension });
@@ -611,7 +611,7 @@ export class ExtensionTipsService extends Disposable implements IExtensionTipsSe
611611
/* __GDPR__
612612
"fileExtensionSuggestion:popup" : {
613613
"userReaction" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
614-
"extensionId": { "classification": "PublicNonPersonalData", "purpose": "FeatureInsight" }
614+
"fileExtension": { "classification": "PublicNonPersonalData", "purpose": "FeatureInsight" }
615615
}
616616
*/
617617
this.telemetryService.publicLog('fileExtensionSuggestion:popup', { userReaction: 'cancelled', fileExtension: fileExtension });
@@ -777,8 +777,8 @@ export class ExtensionTipsService extends Disposable implements IExtensionTipsSe
777777
this._dynamicWorkspaceRecommendations = storedRecommendationsJson['recommendations'];
778778
/* __GDPR__
779779
"dynamicWorkspaceRecommendations" : {
780-
"count" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
781-
"cache" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" }
780+
"count" : { "classification": "SystemMetaData", "purpose": "FeatureInsight", "isMeasurement": true },
781+
"cache" : { "classification": "SystemMetaData", "purpose": "FeatureInsight", "isMeasurement": true }
782782
}
783783
*/
784784
this.telemetryService.publicLog('dynamicWorkspaceRecommendations', { count: this._dynamicWorkspaceRecommendations.length, cache: 1 });

0 commit comments

Comments
 (0)