Skip to content

Commit 38233bc

Browse files
committed
Merge remote-tracking branch 'origin/master' into alex/undo-redo
2 parents 2884918 + b7bfce3 commit 38233bc

166 files changed

Lines changed: 2746 additions & 2111 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.github/commands.json

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -115,18 +115,6 @@
115115
"addLabel": "confirmation-pending",
116116
"removeLabel": "confirmed"
117117
},
118-
{
119-
"type": "comment",
120-
"name": "findDuplicates",
121-
"allowUsers": [
122-
"cleidigh",
123-
"usernamehw",
124-
"gjsjohnmurray",
125-
"IllusionMH"
126-
],
127-
"action": "comment",
128-
"comment": "Potential duplicates:\n${potentialDuplicates}"
129-
},
130118
{
131119
"type": "comment",
132120
"name": "needsMoreInfo",

.github/commands.yml

Lines changed: 154 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,154 @@
1+
# {
2+
# perform: true,
3+
# commands: [
4+
# {
5+
# type: 'comment',
6+
# name: 'findDuplicates',
7+
# allowUsers: ['cleidigh', 'usernamehw', 'gjsjohnmurray', 'IllusionMH'],
8+
# action: 'comment',
9+
# comment: "Potential duplicates:\n${potentialDuplicates}"
10+
# }
11+
# ]
12+
# }
13+
14+
{
15+
perform: true,
16+
commands: [
17+
{
18+
type: 'comment',
19+
name: 'question',
20+
allowUsers: ['cleidigh', 'usernamehw', 'gjsjohnmurray', 'IllusionMH'],
21+
action: 'updateLabels',
22+
addLabel: '*question'
23+
},
24+
{
25+
type: 'label',
26+
name: '*question',
27+
allowTriggerByBot: true,
28+
action: 'close',
29+
comment: "Please ask your question on [StackOverflow](https://aka.ms/vscodestackoverflow). We have a great community over [there](https://aka.ms/vscodestackoverflow). They have already answered thousands of questions and are happy to answer yours as well. See also our [issue reporting](https://aka.ms/vscodeissuereporting) guidelines.\n\nHappy Coding!"
30+
},
31+
{
32+
type: 'label',
33+
name: '*dev-question',
34+
allowTriggerByBot: true,
35+
action: 'close',
36+
comment: "We have a great developer community [over on slack](https://aka.ms/vscode-dev-community) where extension authors help each other. This is a great place for you to ask questions and find support.\n\nHappy Coding!"
37+
},
38+
{
39+
type: 'label',
40+
name: '*extension-candidate',
41+
allowTriggerByBot: true,
42+
action: 'close',
43+
comment: "We try to keep VS Code lean and we think the functionality you're asking for is great for a VS Code extension. Maybe you can already find one that suits you in the [VS Code Marketplace](https://aka.ms/vscodemarketplace). Just in case, in a few simple steps you can get started [writing your own extension](https://aka.ms/vscodewritingextensions). See also our [issue reporting](https://aka.ms/vscodeissuereporting) guidelines.\n\nHappy Coding!"
44+
},
45+
{
46+
type: 'label',
47+
name: '*not-reproducible',
48+
allowTriggerByBot: true,
49+
action: 'close',
50+
comment: "We closed this issue because we are unable to reproduce the problem with the steps you describe. Chances are we've already fixed your problem in a recent version of VS Code. If not, please ask us to reopen the issue and provide us with more detail. Our [issue reporting](https://aka.ms/vscodeissuereporting) guidelines might help you with that.\n\nHappy Coding!"
51+
},
52+
{
53+
type: 'label',
54+
name: '*out-of-scope',
55+
allowTriggerByBot: true,
56+
action: 'close',
57+
comment: "We closed this issue because we don't plan to address it in the foreseeable future. You can find more detailed information about our decision-making process [here](https://aka.ms/vscode-out-of-scope). If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.\n\nIf you wonder what we are up to, please see our [roadmap](https://aka.ms/vscoderoadmap) and [issue reporting](https://aka.ms/vscodeissuereporting) guidelines.\n\nThanks for your understanding and happy coding!"
58+
},
59+
{
60+
type: 'comment',
61+
name: 'causedByExtension',
62+
allowUsers: ['cleidigh', 'usernamehw', 'gjsjohnmurray', 'IllusionMH'],
63+
action: 'updateLabels',
64+
addLabel: '*caused-by-extension'
65+
},
66+
{
67+
type: 'label',
68+
name: '*caused-by-extension',
69+
allowTriggerByBot: true,
70+
action: 'close',
71+
comment: "This issue is caused by an extension, please file it with the repository (or contact) the extension has linked in its overview in VS Code or the [marketplace](https://aka.ms/vscodemarketplace) for VS Code. See also our [issue reporting](https://aka.ms/vscodeissuereporting) guidelines.\n\nHappy Coding!"
72+
},
73+
{
74+
type: 'label',
75+
name: '*as-designed',
76+
allowTriggerByBot: true,
77+
action: 'close',
78+
comment: "The described behavior is how it is expected to work. If you disagree, please explain what is expected and what is not in more detail. See also our [issue reporting](https://aka.ms/vscodeissuereporting) guidelines.\n\nHappy Coding!"
79+
},
80+
{
81+
type: 'label',
82+
name: '*english-please',
83+
allowTriggerByBot: true,
84+
action: 'close',
85+
comment: "This issue is being closed because its description is not in English, that makes it hard for us to work on it. Please open a new issue with an English description. You might find [Bing Translator](https://www.bing.com/translator) useful."
86+
},
87+
{
88+
type: 'comment',
89+
name: 'duplicate',
90+
allowUsers: ['cleidigh', 'usernamehw', 'gjsjohnmurray', 'IllusionMH'],
91+
action: 'updateLabels',
92+
addLabel: '*duplicate'
93+
},
94+
{
95+
type: 'label',
96+
name: '*duplicate',
97+
allowTriggerByBot: true,
98+
action: 'close',
99+
comment: "Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues [here](https://aka.ms/vscodeissuesearch). See also our [issue reporting](https://aka.ms/vscodeissuereporting) guidelines.\n\nHappy Coding!"
100+
},
101+
{
102+
type: 'comment',
103+
name: 'confirm',
104+
allowUsers: ['cleidigh', 'usernamehw', 'gjsjohnmurray', 'IllusionMH'],
105+
action: 'updateLabels',
106+
addLabel: 'confirmed',
107+
removeLabel: 'confirmation-pending'
108+
},
109+
{
110+
type: 'comment',
111+
name: 'confirmationPending',
112+
allowUsers: ['cleidigh', 'usernamehw', 'gjsjohnmurray', 'IllusionMH'],
113+
action: 'updateLabels',
114+
addLabel: 'confirmation-pending',
115+
removeLabel: 'confirmed'
116+
},
117+
{
118+
type: 'comment',
119+
name: 'findDuplicates',
120+
allowUsers: ['cleidigh', 'usernamehw', 'gjsjohnmurray', 'IllusionMH'],
121+
action: 'comment',
122+
comment: "Potential duplicates:\n${potentialDuplicates}"
123+
},
124+
{
125+
type: 'comment',
126+
name: 'needsMoreInfo',
127+
allowUsers: ['cleidigh', 'usernamehw', 'gjsjohnmurray', 'IllusionMH'],
128+
action: 'updateLabels',
129+
addLabel: 'needs more info',
130+
comment: "Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our [issue reporting](https://aka.ms/vscodeissuereporting) guidelines. Please take the time to review these and update the issue.\n\nHappy Coding!"
131+
},
132+
{
133+
type: 'label',
134+
name: '~needs more info',
135+
action: 'updateLabels',
136+
addLabel: 'needs more info',
137+
removeLabel: '~needs more info',
138+
comment: "Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our [issue reporting](https://aka.ms/vscodeissuereporting) guidelines. Please take the time to review these and update the issue.\n\nHappy Coding!"
139+
},
140+
{
141+
type: 'comment',
142+
name: 'a11ymas',
143+
allowUsers: ['AccessibilityTestingTeam-TCS', 'dixitsonali95', 'Mohini78', 'ChitrarupaSharma', 'mspatil110', 'umasarath52', 'v-umnaik'],
144+
action: 'updateLabels',
145+
addLabel: 'a11ymas'
146+
},
147+
{
148+
type: 'label',
149+
name: '*off-topic',
150+
action: 'close',
151+
comment: "Thanks for creating this issue. We think this issue is unactionable or unrelated to the goals of this project. Please follow our [issue reporting](https://aka.ms/vscodeissuereporting) guidelines.\n\nHappy Coding!"
152+
}
153+
]
154+
}

.github/workflows/commands.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@ jobs:
1414
with:
1515
repository: 'JacksonKearl/vscode-triage-github-actions'
1616
ref: v2
17-
- name: Run Commands
18-
uses: ./commands
19-
with:
20-
token: ${{secrets.VSCODE_ISSUE_TRIAGE_BOT_PAT}}
21-
config-path: commands
17+
# - name: Run Commands
18+
# uses: ./commands
19+
# with:
20+
# token: ${{secrets.VSCODE_ISSUE_TRIAGE_BOT_PAT}}
21+
# config-path: commands

.github/workflows/copycat.yml

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -12,15 +12,15 @@ jobs:
1212
with:
1313
repository: 'JacksonKearl/vscode-triage-github-actions'
1414
ref: v2
15-
- name: Run CopyCat (JacksonKearl/testissues)
16-
uses: ./copycat
17-
with:
18-
token: ${{secrets.VSCODE_ISSUE_TRIAGE_BOT_PAT}}
19-
owner: JacksonKearl
20-
repo: testissues
21-
- name: Run CopyCat (chrmarti/testissues)
22-
uses: ./copycat
23-
with:
24-
token: ${{secrets.VSCODE_ISSUE_TRIAGE_BOT_PAT}}
25-
owner: chrmarti
26-
repo: testissues
15+
# - name: Run CopyCat (JacksonKearl/testissues)
16+
# uses: ./copycat
17+
# with:
18+
# token: ${{secrets.VSCODE_ISSUE_TRIAGE_BOT_PAT}}
19+
# owner: JacksonKearl
20+
# repo: testissues
21+
# - name: Run CopyCat (chrmarti/testissues)
22+
# uses: ./copycat
23+
# with:
24+
# token: ${{secrets.VSCODE_ISSUE_TRIAGE_BOT_PAT}}
25+
# owner: chrmarti
26+
# repo: testissues

.github/workflows/needs-version-info.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@ jobs:
1212
with:
1313
repository: 'JacksonKearl/vscode-triage-github-actions'
1414
ref: v2
15-
- name: Run Needs Version Info
16-
uses: ./needs-more-info
17-
with:
18-
token: ${{secrets.VSCODE_ISSUE_TRIAGE_BOT_PAT}}
19-
matcher: '\b(\d\.\d{2,3}\.\d|insiders?|1\.\d\d\d?)\b'
20-
label: ~needs version info
15+
# - name: Run Needs Version Info
16+
# uses: ./needs-more-info
17+
# with:
18+
# token: ${{secrets.VSCODE_ISSUE_TRIAGE_BOT_PAT}}
19+
# matcher: '\b(\d\.\d{2,3}\.\d|insiders?|1\.\d\d\d?)\b'
20+
# label: ~needs version info

build/builtInExtensions.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646
},
4747
{
4848
"name": "ms-vscode.js-debug-nightly",
49-
"version": "2020.3.317",
49+
"version": "2020.3.1117",
5050
"forQualities": [
5151
"insider"
5252
],

build/lib/treeshaking.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -333,7 +333,7 @@ function markNodes(languageService, options) {
333333
}
334334
setColor(node, 2 /* Black */);
335335
black_queue.push(node);
336-
if (options.shakeLevel === 2 /* ClassMembers */ && (ts.isMethodDeclaration(node) || ts.isMethodSignature(node) || ts.isPropertySignature(node) || ts.isGetAccessor(node) || ts.isSetAccessor(node))) {
336+
if (options.shakeLevel === 2 /* ClassMembers */ && (ts.isMethodDeclaration(node) || ts.isMethodSignature(node) || ts.isPropertySignature(node) || ts.isPropertyDeclaration(node) || ts.isGetAccessor(node) || ts.isSetAccessor(node))) {
337337
const references = languageService.getReferencesAtPosition(node.getSourceFile().fileName, node.name.pos + node.name.getLeadingTriviaWidth());
338338
if (references) {
339339
for (let i = 0, len = references.length; i < len; i++) {

build/lib/treeshaking.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -436,7 +436,7 @@ function markNodes(languageService: ts.LanguageService, options: ITreeShakingOpt
436436
setColor(node, NodeColor.Black);
437437
black_queue.push(node);
438438

439-
if (options.shakeLevel === ShakeLevel.ClassMembers && (ts.isMethodDeclaration(node) || ts.isMethodSignature(node) || ts.isPropertySignature(node) || ts.isGetAccessor(node) || ts.isSetAccessor(node))) {
439+
if (options.shakeLevel === ShakeLevel.ClassMembers && (ts.isMethodDeclaration(node) || ts.isMethodSignature(node) || ts.isPropertySignature(node) || ts.isPropertyDeclaration(node) || ts.isGetAccessor(node) || ts.isSetAccessor(node))) {
440440
const references = languageService.getReferencesAtPosition(node.getSourceFile().fileName, node.name.pos + node.name.getLeadingTriviaWidth());
441441
if (references) {
442442
for (let i = 0, len = references.length; i < len; i++) {

build/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,10 @@
4040
"iconv-lite": "0.4.23",
4141
"mime": "^1.3.4",
4242
"minimatch": "3.0.4",
43-
"minimist": "^1.2.0",
43+
"minimist": "^1.2.2",
4444
"request": "^2.85.0",
4545
"terser": "4.3.8",
46-
"typescript": "3.9.0-dev.20200304",
46+
"typescript": "^3.9.0-dev.20200316",
4747
"vsce": "1.48.0",
4848
"vscode-telemetry-extractor": "^1.5.4",
4949
"xml2js": "^0.4.17"

build/yarn.lock

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1780,10 +1780,10 @@ minimatch@3.0.4, minimatch@^3.0.3, minimatch@^3.0.4:
17801780
dependencies:
17811781
brace-expansion "^1.1.7"
17821782

1783-
minimist@^1.1.0, minimist@^1.2.0:
1784-
version "1.2.0"
1785-
resolved "https://registry.yarnpkg.com/minimist/-/minimist-1.2.0.tgz#a35008b20f41383eec1fb914f4cd5df79a264284"
1786-
integrity sha1-o1AIsg9BOD7sH7kU9M1d95omQoQ=
1783+
minimist@^1.1.0, minimist@^1.2.0, minimist@^1.2.2:
1784+
version "1.2.2"
1785+
resolved "https://registry.yarnpkg.com/minimist/-/minimist-1.2.2.tgz#b00a00230a1108c48c169e69a291aafda3aacd63"
1786+
integrity sha512-rIqbOrKb8GJmx/5bc2M0QchhUouMXSpd1RTclXsB41JdL+VtnojfaJR+h7F9k18/4kHUsBFgk80Uk+q569vjPA==
17871787

17881788
minimist@~0.0.1:
17891789
version "0.0.10"
@@ -2453,16 +2453,16 @@ typed-rest-client@^0.9.0:
24532453
tunnel "0.0.4"
24542454
underscore "1.8.3"
24552455

2456-
typescript@3.9.0-dev.20200304:
2457-
version "3.9.0-dev.20200304"
2458-
resolved "https://registry.yarnpkg.com/typescript/-/typescript-3.9.0-dev.20200304.tgz#3cc35357eff29dc5604b4fa56d6597e13daf86ed"
2459-
integrity sha512-eUip/GgJmjp4qtHiJDxVhE5SDDiPzBUg7KBAFUgb7HgL/tv10JAHej7fnS1i+7xrq1eDtbkJyPaYOVnhL9db7Q==
2460-
24612456
typescript@^3.0.1:
24622457
version "3.5.3"
24632458
resolved "https://registry.yarnpkg.com/typescript/-/typescript-3.5.3.tgz#c830f657f93f1ea846819e929092f5fe5983e977"
24642459
integrity sha512-ACzBtm/PhXBDId6a6sDJfroT2pOWt/oOnk4/dElG5G33ZL776N3Y6/6bKZJBFpd+b05F3Ct9qDjMeJmRWtE2/g==
24652460

2461+
typescript@^3.9.0-dev.20200316:
2462+
version "3.9.0-dev.20200316"
2463+
resolved "https://registry.yarnpkg.com/typescript/-/typescript-3.9.0-dev.20200316.tgz#7cbb2fa2eedf58eea27b3250ab38674790ccf999"
2464+
integrity sha512-MM67isAuvHM4hwfHR4K9NikB7MFD9RjISB5cXhtKmjkpMFO0QNzFmFq061VmsJqoRVpG9N2KE+cm6BJ9dIjrtQ==
2465+
24662466
typical@^4.0.0:
24672467
version "4.0.0"
24682468
resolved "https://registry.yarnpkg.com/typical/-/typical-4.0.0.tgz#cbeaff3b9d7ae1e2bbfaf5a4e6f11eccfde94fc4"

0 commit comments

Comments
 (0)