Fix more lgtm.com issues

roblourens · roblourens · commit 35eae99ec354 · 2019-01-17T18:06:23.000Z
diff --git a/extensions/emmet/src/abbreviationActions.ts b/extensions/emmet/src/abbreviationActions.ts
@@ -7,8 +7,8 @@ import * as vscode from 'vscode';
 import { Node, HtmlNode, Rule, Property, Stylesheet } from 'EmmetNode';
 import { getEmmetHelper, getNode, getInnerRange, getMappingForIncludedLanguages, parseDocument, validate, getEmmetConfiguration, isStyleSheet, getEmmetMode, parsePartialStylesheet, isStyleAttribute, getEmbeddedCssNodeIfAny, allowedMimeTypesInScriptTag } from './util';
 
-const trimRegex = /[\u00a0]*[\d|#|\-|\*|\u2022]+\.?/;
-const hexColorRegex = /^#[\d,a-f,A-F]{0,6}$/;
+const trimRegex = /[\u00a0]*[\d#\-\*\u2022]+\.?/;
+const hexColorRegex = /^#[\da-fA-F]{0,6}$/;
 const inlineElements = ['a', 'abbr', 'acronym', 'applet', 'b', 'basefont', 'bdo',
 	'big', 'br', 'button', 'cite', 'code', 'del', 'dfn', 'em', 'font', 'i',
 	'iframe', 'img', 'input', 'ins', 'kbd', 'label', 'map', 'object', 'q',
diff --git a/src/vs/base/common/assert.ts b/src/vs/base/common/assert.ts
@@ -7,7 +7,7 @@
  * Throws an error with the provided message if the provided value does not evaluate to a true Javascript value.
  */
 export function ok(value?: any, message?: string) {
-	if (!value || value === null) {
+	if (!value) {
 		throw new Error(message ? 'Assertion failed (' + message + ')' : 'Assertion Failed');
 	}
 }
diff --git a/src/vs/base/common/types.ts b/src/vs/base/common/types.ts
@@ -124,7 +124,7 @@ export function isFunction(obj: any): obj is Function {
  * @returns whether the provided parameters is are JavaScript Function or not.
  */
 export function areFunctions(...objects: any[]): boolean {
-	return objects && objects.length > 0 && objects.every(isFunction);
+	return objects.length > 0 && objects.every(isFunction);
 }
 
 export type TypeConstraint = string | Function;
diff --git a/src/vs/workbench/parts/search/browser/openAnythingHandler.ts b/src/vs/workbench/parts/search/browser/openAnythingHandler.ts
@@ -32,7 +32,7 @@ export class OpenAnythingHandler extends QuickOpenHandler {
 
 	static readonly ID = 'workbench.picker.anything';
 
-	private static readonly LINE_COLON_PATTERN = /[#|:|\(](\d*)([#|:|,](\d*))?\)?$/;
+	private static readonly LINE_COLON_PATTERN = /[#:\(](\d*)([#:,](\d*))?\)?$/;
 
 	private static readonly TYPING_SEARCH_DELAY = 200; // This delay accommodates for the user typing a word and then stops typing to start searching
 

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`* Throws an error with the provided message if the provided value does not evaluate to a true Javascript value.`
`8`	`8`	`*/`
`9`	`9`	`export function ok(value?: any, message?: string) {`
`10`		`- if (!value \|\| value === null) {`
	`10`	`+ if (!value) {`
`11`	`11`	`throw new Error(message ? 'Assertion failed (' + message + ')' : 'Assertion Failed');`
`12`	`12`	`}`
`13`	`13`	`}`
Original file line number	Diff line number	Diff line change
`@@ -124,7 +124,7 @@ export function isFunction(obj: any): obj is Function {`
`124`	`124`	`* @returns whether the provided parameters is are JavaScript Function or not.`
`125`	`125`	`*/`
`126`	`126`	`export function areFunctions(...objects: any[]): boolean {`
`127`		`- return objects && objects.length > 0 && objects.every(isFunction);`
	`127`	`+ return objects.length > 0 && objects.every(isFunction);`
`128`	`128`	`}`
`129`	`129`
`130`	`130`	`export type TypeConstraint = string \| Function;`