should -> must for microsoft#85841

octref · octref · commit 35a8880109f2 · 2019-12-05T16:57:11.000-08:00
diff --git a/src/vs/workbench/services/preferences/common/preferencesModels.ts b/src/vs/workbench/services/preferences/common/preferencesModels.ts
@@ -1051,12 +1051,12 @@ export function createValidator(prop: IConfigurationPropertySchema): (value: any
 				}
 
 				if (prop.minItems && stringArrayValue.length < prop.minItems) {
-					message += nls.localize('validations.stringArrayMinItem', 'Array should have at least {0} items', prop.minItems);
+					message += nls.localize('validations.stringArrayMinItem', 'Array must have at least {0} items', prop.minItems);
 					message += '\n';
 				}
 
 				if (prop.maxItems && stringArrayValue.length > prop.maxItems) {
-					message += nls.localize('validations.stringArrayMaxItem', 'Array should have at most {0} items', prop.maxItems);
+					message += nls.localize('validations.stringArrayMaxItem', 'Array must have at most {0} items', prop.maxItems);
 					message += '\n';
 				}
 
diff --git a/src/vs/workbench/services/preferences/test/common/preferencesModel.test.ts b/src/vs/workbench/services/preferences/test/common/preferencesModel.test.ts
@@ -288,10 +288,10 @@ suite('Preferences Model test', () => {
 	test('min-max items array', () => {
 		{
 			const arr = new ArrayTester({ type: 'array', items: { type: 'string' }, minItems: 1, maxItems: 2 });
-			arr.rejects([]).withMessage('Array should have at least 1 items');
+			arr.rejects([]).withMessage('Array must have at least 1 items');
 			arr.accepts(['a']);
 			arr.accepts(['a', 'a']);
-			arr.rejects(['a', 'a', 'a']).withMessage('Array should have at most 2 items');
+			arr.rejects(['a', 'a', 'a']).withMessage('Array must have at most 2 items');
 		}
 	});
 
@@ -312,7 +312,7 @@ suite('Preferences Model test', () => {
 	test('min-max and enum', () => {
 		const arr = new ArrayTester({ type: 'array', items: { type: 'string', enum: ['a', 'b'] }, minItems: 1, maxItems: 2 });
 
-		arr.rejects(['a', 'b', 'c']).withMessage('Array should have at most 2 items');
+		arr.rejects(['a', 'b', 'c']).withMessage('Array must have at most 2 items');
 		arr.rejects(['a', 'b', 'c']).withMessage(`Value 'c' is not one of`);
 	});
 

Original file line number	Diff line number	Diff line change
`@@ -1051,12 +1051,12 @@ export function createValidator(prop: IConfigurationPropertySchema): (value: any`
`1051`	`1051`	`}`
`1052`	`1052`
`1053`	`1053`	`if (prop.minItems && stringArrayValue.length < prop.minItems) {`
`1054`		`- message += nls.localize('validations.stringArrayMinItem', 'Array should have at least {0} items', prop.minItems);`
	`1054`	`+ message += nls.localize('validations.stringArrayMinItem', 'Array must have at least {0} items', prop.minItems);`
`1055`	`1055`	`message += '\n';`
`1056`	`1056`	`}`
`1057`	`1057`
`1058`	`1058`	`if (prop.maxItems && stringArrayValue.length > prop.maxItems) {`
`1059`		`- message += nls.localize('validations.stringArrayMaxItem', 'Array should have at most {0} items', prop.maxItems);`
	`1059`	`+ message += nls.localize('validations.stringArrayMaxItem', 'Array must have at most {0} items', prop.maxItems);`
`1060`	`1060`	`message += '\n';`
`1061`	`1061`	`}`
`1062`	`1062`