breadcrumbs - don't leak a listener

jrieken · jrieken · commit 34a667a828e2 · 2018-08-15T12:42:36.000+02:00
diff --git a/src/vs/workbench/browser/parts/editor/titleControl.ts b/src/vs/workbench/browser/parts/editor/titleControl.ts
@@ -97,7 +97,7 @@ export abstract class TitleControl extends Themable {
 
 	protected createBreadcrumbsControl(container: HTMLElement, options: IBreadcrumbsControlOptions): void {
 		const config = this._register(BreadcrumbsConfig.IsEnabled.bindTo(this.configurationService));
-		config.onDidChange(value => {
+		this._register(config.onDidChange(value => {
 			if (!value && this.breadcrumbsControl) {
 				this.breadcrumbsControl.dispose();
 				this.breadcrumbsControl = undefined;
@@ -107,7 +107,7 @@ export abstract class TitleControl extends Themable {
 				this.breadcrumbsControl.update();
 				this.handleBreadcrumbsEnablementChange();
 			}
-		});
+		}));
 		if (config.value) {
 			this.breadcrumbsControl = this.instantiationService.createInstance(BreadcrumbsControl, container, options, this.group);
 		}
