Skip to content

Commit 3254ba1

Browse files
committed
Revert "more logging for microsoft#100524"
This reverts commit 933e3fa.
1 parent fd4d8dd commit 3254ba1

1 file changed

Lines changed: 3 additions & 9 deletions

File tree

src/vs/workbench/services/decorations/browser/decorationsService.ts

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -208,8 +208,7 @@ class DecorationProviderWrapper {
208208
constructor(
209209
readonly provider: IDecorationsProvider,
210210
private readonly _uriEmitter: Emitter<URI | URI[]>,
211-
private readonly _flushEmitter: Emitter<IResourceDecorationChangeEvent>,
212-
@ILogService private readonly _logService: ILogService,
211+
private readonly _flushEmitter: Emitter<IResourceDecorationChangeEvent>
213212
) {
214213
this._dispoable = this.provider.onDidChange(uris => {
215214
if (!uris) {
@@ -239,17 +238,16 @@ class DecorationProviderWrapper {
239238
}
240239

241240
getOrRetrieve(uri: URI, includeChildren: boolean, callback: (data: IDecorationData, isChild: boolean) => void): void {
241+
242242
let item = this.data.get(uri);
243243

244244
if (item === undefined) {
245245
// unknown -> trigger request
246-
this._logService.trace('[Decorations] getOrRetrieve -> FETCH', this.provider.label, uri);
247246
item = this._fetchData(uri);
248247
}
249248

250249
if (item && !(item instanceof DecorationDataRequest)) {
251250
// found something (which isn't pending anymore)
252-
this._logService.trace('[Decorations] getOrRetrieve -> RESULT', this.provider.label, uri);
253251
callback(item, false);
254252
}
255253

@@ -259,7 +257,6 @@ class DecorationProviderWrapper {
259257
if (iter) {
260258
for (let item = iter.next(); !item.done; item = iter.next()) {
261259
if (item.value && !(item.value instanceof DecorationDataRequest)) {
262-
this._logService.trace('[Decorations] getOrRetrieve -> RESULT (children)', this.provider.label, uri);
263260
callback(item.value, true);
264261
}
265262
}
@@ -272,7 +269,6 @@ class DecorationProviderWrapper {
272269
// check for pending request and cancel it
273270
const pendingRequest = this.data.get(uri);
274271
if (pendingRequest instanceof DecorationDataRequest) {
275-
this._logService.trace('[Decorations] fetchData -> CANCEL previous', this.provider.label, uri);
276272
pendingRequest.source.cancel();
277273
this.data.delete(uri);
278274
}
@@ -301,7 +297,6 @@ class DecorationProviderWrapper {
301297
}
302298

303299
private _keepItem(uri: URI, data: IDecorationData | undefined): IDecorationData | null {
304-
this._logService.trace('[Decorations] keepItem -> CANCEL previous', this.provider.label, uri, data);
305300
const deco = data ? data : null;
306301
const old = this.data.set(uri, deco);
307302
if (deco || old) {
@@ -348,8 +343,7 @@ export class DecorationsService implements IDecorationsService {
348343
const wrapper = new DecorationProviderWrapper(
349344
provider,
350345
this._onDidChangeDecorationsDelayed,
351-
this._onDidChangeDecorations,
352-
this._logService
346+
this._onDidChangeDecorations
353347
);
354348
const remove = this._data.push(wrapper);
355349

0 commit comments

Comments
 (0)