Also remove extHostWebview side of the api proposal for webview editor state/save

mjbvz · mjbvz · commit 313ede61cbad · 2019-09-30T20:36:21.000-07:00
diff --git a/src/vs/workbench/api/common/extHostTypeConverters.ts b/src/vs/workbench/api/common/extHostTypeConverters.ts
@@ -1163,13 +1163,3 @@ export namespace LogLevel {
 		return types.LogLevel.Info;
 	}
 }
-export namespace WebviewContentState {
-	export function from(state: vscode.WebviewContentState): modes.WebviewContentState {
-		switch (state) {
-			case types.WebviewContentState.Readonly: return modes.WebviewContentState.Readonly;
-			case types.WebviewContentState.Unchanged: return modes.WebviewContentState.Unchanged;
-			case types.WebviewContentState.Dirty: return modes.WebviewContentState.Dirty;
-			default: throw new Error('Unknown vscode.WebviewContentState');
-		}
-	}
-}
diff --git a/src/vs/workbench/api/common/extHostWebview.ts b/src/vs/workbench/api/common/extHostWebview.ts
@@ -13,7 +13,7 @@ import { EditorViewColumn } from 'vs/workbench/api/common/shared/editor';
 import { asWebviewUri, WebviewInitData } from 'vs/workbench/api/common/shared/webview';
 import * as vscode from 'vscode';
 import { ExtHostWebviewsShape, IMainContext, MainContext, MainThreadWebviewsShape, WebviewPanelHandle, WebviewPanelViewStateData } from './extHost.protocol';
-import { Disposable, WebviewContentState } from './extHostTypes';
+import { Disposable } from './extHostTypes';
 
 type IconPath = URI | { light: URI, dark: URI };
 
@@ -102,9 +102,6 @@ export class ExtHostWebviewEditor implements vscode.WebviewEditor {
 	private _viewColumn: vscode.ViewColumn | undefined;
 	private _visible: boolean = true;
 	private _active: boolean = true;
-	private _state: vscode.WebviewEditorState = {
-		contentState: WebviewContentState.Readonly,
-	};
 
 	_isDisposed: boolean = false;
 
@@ -224,15 +221,6 @@ export class ExtHostWebviewEditor implements vscode.WebviewEditor {
 		this._visible = value;
 	}
 
-	public get editorState(): vscode.WebviewEditorState {
-		return this._state;
-	}
-
-	public set editorState(newState: vscode.WebviewEditorState) {
-		this._state = newState;
-		this._proxy.$setState(this._handle, typeConverters.WebviewContentState.from(newState.contentState));
-	}
-
 	private readonly _onWillSave = new Emitter<{ waitUntil: (thenable: Thenable<boolean>) => void }>();
 	public readonly onWillSave = this._onWillSave.event;
 

Original file line number	Diff line number	Diff line change
`@@ -1163,13 +1163,3 @@ export namespace LogLevel {`
`1163`	`1163`	`return types.LogLevel.Info;`
`1164`	`1164`	`}`
`1165`	`1165`	`}`
`1166`		`-export namespace WebviewContentState {`
`1167`		`- export function from(state: vscode.WebviewContentState): modes.WebviewContentState {`
`1168`		`- switch (state) {`
`1169`		`- case types.WebviewContentState.Readonly: return modes.WebviewContentState.Readonly;`
`1170`		`- case types.WebviewContentState.Unchanged: return modes.WebviewContentState.Unchanged;`
`1171`		`- case types.WebviewContentState.Dirty: return modes.WebviewContentState.Dirty;`
`1172`		`- default: throw new Error('Unknown vscode.WebviewContentState');`
`1173`		`- }`
`1174`		`- }`
`1175`		`-}`