Don't try to revive webviews without a reviver

mjbvz · mjbvz · commit 302cbc143fb3 · 2018-05-14T11:06:05.000-07:00
diff --git a/src/vs/workbench/api/electron-browser/mainThreadWebview.ts b/src/vs/workbench/api/electron-browser/mainThreadWebview.ts
@@ -134,7 +134,14 @@ export class MainThreadWebviews implements MainThreadWebviewsShape, WebviewReviv
 			this._webviews.set(handle, webview);
 			webview._events = this.createWebviewEventDelegate(handle);
 
-			return this._proxy.$deserializeWebviewPanel(handle, webview.state.viewType, webview.getTitle(), JSON.parse(webview.state.state), webview.position, webview.options)
+			let state;
+			try {
+				state = JSON.parse(webview.state.state);
+			} catch {
+				state = {};
+			}
+
+			return this._proxy.$deserializeWebviewPanel(handle, webview.state.viewType, webview.getTitle(), state, webview.position, webview.options)
 				.then(undefined, () => {
 					webview.html = MainThreadWebviews.getDeserializationFailedContents(viewType);
 				});
@@ -146,7 +153,7 @@ export class MainThreadWebviews implements MainThreadWebviewsShape, WebviewReviv
 			return false;
 		}
 
-		return this._revivers.has(webview.viewType) || webview.reviver !== null;
+		return (this._revivers.has(webview.viewType) || webview.reviver !== null) && webview.state.state;
 	}
 
 	private _onWillShutdown(): TPromise<boolean> {
