microsoft#2882 ui affordance for disablement

sandy081 · sandy081 · commit 2ff7e262b6b0 · 2016-10-24T15:08:03.000+02:00
diff --git a/src/vs/workbench/parts/extensions/electron-browser/extensionsActions.ts b/src/vs/workbench/parts/extensions/electron-browser/extensionsActions.ts
@@ -398,7 +398,7 @@ export class EnableAction extends Action {
 			return;
 		}
 
-		this.enabled = this.extension.type !== LocalExtensionType.System && !this.extension.reload && this.extensionsRuntimeService.canEnable(this.extension.identifier);
+		this.enabled = this.extension.type !== LocalExtensionType.System && !this.extension.reload && ExtensionState.Disabled === this.extension.state && this.extensionsRuntimeService.canEnable(this.extension.identifier);
 		this.class = this.enabled ? EnableAction.EnabledClass : EnableAction.DisabledClass;
 	}
 
diff --git a/src/vs/workbench/parts/extensions/electron-browser/extensionsList.ts b/src/vs/workbench/parts/extensions/electron-browser/extensionsList.ts
@@ -5,7 +5,7 @@
 
 'use strict';
 
-import { append, $, addClass, removeClass } from 'vs/base/browser/dom';
+import { append, $, addClass, removeClass, toggleClass } from 'vs/base/browser/dom';
 import { IDisposable, dispose } from 'vs/base/common/lifecycle';
 import { Action } from 'vs/base/common/actions';
 import { ActionBar } from 'vs/base/browser/ui/actionbar/actionbar';
@@ -15,7 +15,7 @@ import { IDelegate } from 'vs/base/browser/ui/list/list';
 import { IPagedRenderer } from 'vs/base/browser/ui/list/listPaging';
 import { once } from 'vs/base/common/event';
 import { domEvent } from 'vs/base/browser/event';
-import { IExtension } from '../common/extensions';
+import { IExtension, ExtensionState } from '../common/extensions';
 import { CombinedInstallAction, UpdateAction, EnableAction, DisableAction, BuiltinStatusLabelAction, ReloadAction } from './extensionsActions';
 import { Label, RatingsWidget, InstallWidget } from './extensionsWidgets';
 import { EventType } from 'vs/base/common/events';
@@ -126,6 +126,8 @@ export class Renderer implements IPagedRenderer<IExtension, ITemplateData> {
 
 		data.extensionDisposables = dispose(data.extensionDisposables);
 
+		toggleClass(data.element, 'disabled', ExtensionState.Disabled === extension.state);
+
 		const onError = once(domEvent(data.icon, 'error'));
 		onError(() => data.icon.src = extension.iconUrlFallback, null, data.extensionDisposables);
 		data.icon.src = extension.iconUrl;
diff --git a/src/vs/workbench/parts/extensions/electron-browser/media/extensionsViewlet.css b/src/vs/workbench/parts/extensions/electron-browser/media/extensionsViewlet.css
@@ -140,6 +140,13 @@
 	line-height: 15px;
 }
 
+.extensions-viewlet > .extensions .extension.disabled > .icon,
+.extensions-viewlet > .extensions .extension.disabled > .details > .header-container,
+.extensions-viewlet > .extensions .extension.disabled > .details > .description,
+.extensions-viewlet > .extensions .extension.disabled > .details > .footer > .author {
+	opacity: 0.5;
+}
+
 .extensions-viewlet > .extensions .extension .ellipsis {
 	overflow: hidden;
 	white-space: nowrap;

Original file line number	Diff line number	Diff line change
`@@ -398,7 +398,7 @@ export class EnableAction extends Action {`
`398`	`398`	`return;`
`399`	`399`	`}`
`400`	`400`
`401`		`- this.enabled = this.extension.type !== LocalExtensionType.System && !this.extension.reload && this.extensionsRuntimeService.canEnable(this.extension.identifier);`
	`401`	`+ this.enabled = this.extension.type !== LocalExtensionType.System && !this.extension.reload && ExtensionState.Disabled === this.extension.state && this.extensionsRuntimeService.canEnable(this.extension.identifier);`
`402`	`402`	`this.class = this.enabled ? EnableAction.EnabledClass : EnableAction.DisabledClass;`
`403`	`403`	`}`
`404`	`404`