Skip to content

Commit 2f863c6

Browse files
committed
remove TPromise.wrapError
related to microsoft#63897
1 parent 346b230 commit 2f863c6

1 file changed

Lines changed: 8 additions & 11 deletions

File tree

src/vs/workbench/parts/update/electron-browser/releaseNotesEditor.ts

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import { onUnexpectedError } from 'vs/base/common/errors';
77
import * as marked from 'vs/base/common/marked/marked';
88
import { OS } from 'vs/base/common/platform';
99
import { URI } from 'vs/base/common/uri';
10-
import { TPromise } from 'vs/base/common/winjs.base';
1110
import { asText } from 'vs/base/node/request';
1211
import { TokenizationRegistry, ITokenizationSupport } from 'vs/editor/common/modes';
1312
import { generateTokensCSSForColorMap } from 'vs/editor/common/modes/supports/tokenization';
@@ -48,7 +47,7 @@ function renderBody(
4847

4948
export class ReleaseNotesManager {
5049

51-
private _releaseNotesCache: { [version: string]: TPromise<string>; } = Object.create(null);
50+
private _releaseNotesCache: { [version: string]: Thenable<string>; } = Object.create(null);
5251

5352
private _currentReleaseNotes: WebviewEditorInput | undefined = undefined;
5453
private _lastText: string;
@@ -111,12 +110,10 @@ export class ReleaseNotesManager {
111110
return true;
112111
}
113112

114-
private loadReleaseNotes(
115-
version: string
116-
): TPromise<string> {
113+
private loadReleaseNotes(version: string): Thenable<string> {
117114
const match = /^(\d+\.\d+)\./.exec(version);
118115
if (!match) {
119-
return TPromise.wrapError<string>(new Error('not found'));
116+
return Promise.reject(new Error('not found'));
120117
}
121118

122119
const versionLabel = match[1].replace(/\./g, '_');
@@ -161,10 +158,10 @@ export class ReleaseNotesManager {
161158
.then(asText)
162159
.then(text => {
163160
if (!/^#\s/.test(text)) { // release notes always starts with `#` followed by whitespace
164-
return TPromise.wrapError<string>(new Error('Invalid release notes'));
161+
return Promise.reject(new Error('Invalid release notes'));
165162
}
166163

167-
return TPromise.wrap(text);
164+
return Promise.resolve(text);
168165
})
169166
.then(text => patchKeybindings(text));
170167
}
@@ -191,8 +188,8 @@ export class ReleaseNotesManager {
191188
return marked(text, { renderer });
192189
}
193190

194-
private async getRenderer(text: string) {
195-
let result: TPromise<ITokenizationSupport>[] = [];
191+
private async getRenderer(text: string): Promise<marked.Renderer> {
192+
let result: Thenable<ITokenizationSupport>[] = [];
196193
const renderer = new marked.Renderer();
197194
renderer.code = (code, lang) => {
198195
const modeId = this._modeService.getModeIdForLanguageName(lang);
@@ -204,7 +201,7 @@ export class ReleaseNotesManager {
204201
};
205202

206203
marked(text, { renderer });
207-
await TPromise.join(result);
204+
await Promise.all(result);
208205

209206
renderer.code = (code, lang) => `<code>${tokenizeToString(code, TokenizationRegistry.get(lang))}</code>`;
210207
return renderer;

0 commit comments

Comments
 (0)