Fixes 36588: TypeScript build task fails when path to tsconfig.json file has spaces

dbaeumer · dbaeumer · commit 2da853a362a6 · 2018-03-12T12:34:49.000+01:00
diff --git a/extensions/typescript/src/features/taskProvider.ts b/extensions/typescript/src/features/taskProvider.ts
@@ -186,7 +186,7 @@ class TscTaskProvider implements vscode.TaskProvider {
 				project.workspaceFolder || vscode.TaskScope.Workspace,
 				localize('buildTscLabel', 'build - {0}', label),
 				'tsc',
-				new vscode.ShellExecution(`${command} -p "${project.path}"`),
+				new vscode.ShellExecution(command, ['-p', project.path]),
 				'$tsc');
 			buildTask.group = vscode.TaskGroup.Build;
 			buildTask.isBackground = false;
@@ -200,7 +200,7 @@ class TscTaskProvider implements vscode.TaskProvider {
 				project.workspaceFolder || vscode.TaskScope.Workspace,
 				localize('buildAndWatchTscLabel', 'watch - {0}', label),
 				'tsc',
-				new vscode.ShellExecution(`${command} --watch -p "${project.path}"`),
+				new vscode.ShellExecution(command, ['--watch', '-p', project.path]),
 				'$tsc-watch');
 			watchTask.group = vscode.TaskGroup.Build;
 			watchTask.isBackground = true;
