fix: don't use appendArgument to add switch values (microsoft#84320)

deepak1556 · web-flow · commit 2c79231817aa · 2019-11-11T09:44:57.000-08:00
* fix: don't use appendArgument to add switch values

* args - make sure to allow to enabe color correct rendering
diff --git a/src/main.js b/src/main.js
@@ -147,13 +147,9 @@ function configureCommandlineSwitchesSync(cliArgs) {
 		if (argvValue === true || argvValue === 'true') {
 			if (argvKey === 'disable-hardware-acceleration') {
 				app.disableHardwareAcceleration(); // needs to be called explicitly
-			} else if (argvKey === 'disable-color-correct-rendering') {
-				app.commandLine.appendSwitch('disable-color-correct-rendering'); // needs to be called exactly like this (https://github.com/microsoft/vscode/issues/84154)
 			} else {
-				app.commandLine.appendArgument(argvKey);
+				app.commandLine.appendSwitch(argvKey);
 			}
-		} else {
-			app.commandLine.appendSwitch(argvKey, argvValue);
 		}
 	});
 

Original file line number	Diff line number	Diff line change
`@@ -147,13 +147,9 @@ function configureCommandlineSwitchesSync(cliArgs) {`
`147`	`147`	`if (argvValue === true \|\| argvValue === 'true') {`
`148`	`148`	`if (argvKey === 'disable-hardware-acceleration') {`
`149`	`149`	`app.disableHardwareAcceleration(); // needs to be called explicitly`
`150`		`- } else if (argvKey === 'disable-color-correct-rendering') {`
`151`		`- app.commandLine.appendSwitch('disable-color-correct-rendering'); // needs to be called exactly like this (https://github.com/microsoft/vscode/issues/84154)`
`152`	`150`	`} else {`
`153`		`- app.commandLine.appendArgument(argvKey);`
	`151`	`+ app.commandLine.appendSwitch(argvKey);`
`154`	`152`	`}`
`155`		`- } else {`
`156`		`- app.commandLine.appendSwitch(argvKey, argvValue);`
`157`	`153`	`}`
`158`	`154`	`});`
`159`	`155`