Fix task delete debt

alexr00 · alexr00 · commit 2c76aee03ed4 · 2020-04-24T10:46:02.000+02:00
Part of microsoft#96022
diff --git a/src/vs/workbench/contrib/tasks/browser/taskQuickPick.ts b/src/vs/workbench/contrib/tasks/browser/taskQuickPick.ts
@@ -5,7 +5,7 @@
 
 import * as nls from 'vs/nls';
 import * as Objects from 'vs/base/common/objects';
-import { Task, ContributedTask, CustomTask, ConfiguringTask, TaskSorter } from 'vs/workbench/contrib/tasks/common/tasks';
+import { Task, ContributedTask, CustomTask, ConfiguringTask, TaskSorter, KeyedTaskIdentifier } from 'vs/workbench/contrib/tasks/common/tasks';
 import { IWorkspace, IWorkspaceFolder } from 'vs/platform/workspace/common/workspace';
 import * as Types from 'vs/base/common/types';
 import { ITaskService, WorkspaceFolderTaskResult } from 'vs/workbench/contrib/tasks/common/taskService';
@@ -52,7 +52,7 @@ export class TaskQuickPick extends Disposable {
 		}
 		if (ConfiguringTask.is(task)) {
 			let label: string = task.configures.type;
-			const configures = Objects.deepClone(task.configures);
+			const configures: Partial<KeyedTaskIdentifier> = Objects.deepClone(task.configures);
 			delete configures['_key'];
 			delete configures['type'];
 			Object.keys(configures).forEach(key => label += `: ${configures[key]}`);
diff --git a/src/vs/workbench/contrib/tasks/common/taskConfiguration.ts b/src/vs/workbench/contrib/tasks/common/taskConfiguration.ts
@@ -1197,7 +1197,7 @@ namespace ProblemMatcherConverter {
 				if (global) {
 					return Objects.deepClone(global);
 				}
-				let localProblemMatcher = context.namedProblemMatchers[variableName];
+				let localProblemMatcher: ProblemMatcher & Partial<NamedProblemMatcher> = context.namedProblemMatchers[variableName];
 				if (localProblemMatcher) {
 					localProblemMatcher = Objects.deepClone(localProblemMatcher);
 					// remove the name

Original file line number	Diff line number	Diff line change
`@@ -1197,7 +1197,7 @@ namespace ProblemMatcherConverter {`
`1197`	`1197`	`if (global) {`
`1198`	`1198`	`return Objects.deepClone(global);`
`1199`	`1199`	`}`
`1200`		`- let localProblemMatcher = context.namedProblemMatchers[variableName];`
	`1200`	`+ let localProblemMatcher: ProblemMatcher & Partial<NamedProblemMatcher> = context.namedProblemMatchers[variableName];`
`1201`	`1201`	`if (localProblemMatcher) {`
`1202`	`1202`	`localProblemMatcher = Objects.deepClone(localProblemMatcher);`
`1203`	`1203`	`// remove the name`