tweak d.ts to avoid security and deprecation pitfalls

Benjamin Pasero · Benjamin Pasero · commit 2a299bb9d039 · 2018-08-22T15:32:11.000+02:00
diff --git a/src/typings/electron.d.ts b/src/typings/electron.d.ts
@@ -6374,7 +6374,7 @@ declare namespace Electron {
 		 * When this attribute is present the guest page will be allowed to open new
 		 * windows. Popups are disabled by default.
 		 */
-		allowpopups?: string;
+		// allowpopups?: string; ### VSCODE CHANGE (https://github.com/electron/electron/blob/master/docs/tutorial/security.md) ###
 		/**
 		 * When this attribute is present the webview container will automatically resize
 		 * within the bounds specified by the attributes minwidth, minheight, maxwidth, and
@@ -6407,7 +6407,7 @@ declare namespace Electron {
 		 * When this attribute is present the guest page will have web security disabled.
 		 * Web security is enabled by default.
 		 */
-		disablewebsecurity?: string;
+		// disablewebsecurity?: string; ### VSCODE CHANGE(https://github.com/electron/electron/blob/master/docs/tutorial/security.md) ###
 		/**
 		 * A value that links the webview to a specific webContents. When a webview first
 		 * loads a new webContents is created and this attribute is set to its instance
@@ -8633,12 +8633,12 @@ declare namespace Electron {
 		 * websites by people), and set allowRunningInsecureContent to true if this options
 		 * has not been set by user. Default is true.
 		 */
-		webSecurity?: boolean;
+		// webSecurity?: boolean; ### VSCODE CHANGE (https://github.com/electron/electron/blob/master/docs/tutorial/security.md) ###
 		/**
 		 * Allow an https page to run JavaScript, CSS or plugins from http URLs. Default is
 		 * false.
 		 */
-		allowRunningInsecureContent?: boolean;
+		// allowRunningInsecureContent?: boolean; ### VSCODE CHANGE (https://github.com/electron/electron/blob/master/docs/tutorial/security.md) ###
 		/**
 		 * Enables image support. Default is true.
 		 */
@@ -8662,7 +8662,7 @@ declare namespace Electron {
 		/**
 		 * Enables Chromium's experimental features. Default is false.
 		 */
-		experimentalFeatures?: boolean;
+		// experimentalFeatures?: boolean; ### VSCODE CHANGE (https://github.com/electron/electron/blob/master/docs/tutorial/security.md) ###
 		/**
 		 * Enables Chromium's experimental canvas features. Default is false.
 		 */
diff --git a/src/typings/node.d.ts b/src/typings/node.d.ts
@@ -192,39 +192,39 @@ declare var Buffer: {
      * @param str String to store in buffer.
      * @param encoding encoding to use, optional.  Default is 'utf8'
      */
-    new(str: string, encoding?: string): Buffer;
+    // new(str: string, encoding?: string): Buffer; ### VSCODE CHANGE (new Buffer() is deprecated)
     /**
      * Allocates a new buffer of {size} octets.
      *
      * @param size count of octets to allocate.
      */
-    new(size: number): Buffer;
+    // new(size: number): Buffer; ### VSCODE CHANGE (new Buffer() is deprecated)
     /**
      * Allocates a new buffer containing the given {array} of octets.
      *
      * @param array The octets to store.
      */
-    new(array: Uint8Array): Buffer;
+    // new(array: Uint8Array): Buffer; ### VSCODE CHANGE (new Buffer() is deprecated)
     /**
      * Produces a Buffer backed by the same allocated memory as
      * the given {ArrayBuffer}.
      *
      *
      * @param arrayBuffer The ArrayBuffer with which to share memory.
      */
-    new(arrayBuffer: ArrayBuffer): Buffer;
+    // new(arrayBuffer: ArrayBuffer): Buffer; ### VSCODE CHANGE (new Buffer() is deprecated)
     /**
      * Allocates a new buffer containing the given {array} of octets.
      *
      * @param array The octets to store.
      */
-    new(array: any[]): Buffer;
+    // new(array: any[]): Buffer; ### VSCODE CHANGE (new Buffer() is deprecated)
     /**
      * Copies the passed {buffer} data onto a new {Buffer} instance.
      *
      * @param buffer The buffer to copy.
      */
-    new(buffer: Buffer): Buffer;
+    // new(buffer: Buffer): Buffer; ### VSCODE CHANGE (new Buffer() is deprecated)
     prototype: Buffer;
     /**
      * When passed a reference to the .buffer property of a TypedArray instance,
diff --git a/src/vs/platform/download/node/downloadIpc.ts b/src/vs/platform/download/node/downloadIpc.ts
@@ -69,7 +69,7 @@ export class DownloadServiceChannelClient implements IDownloadService {
 							out.end();
 							disposable.dispose();
 							c(null);
-						} else if (result instanceof Buffer) {
+						} else if (Buffer.isBuffer(result)) {
 							out.write(result);
 						} else if (typeof result === 'string') {
 							out.close();
