Skip to content

Commit 29ebd4b

Browse files
committed
microsoft#1587 Hygiene fixes
1 parent 3af429f commit 29ebd4b

4 files changed

Lines changed: 5 additions & 8 deletions

File tree

src/vs/platform/configuration/common/configuration.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
*--------------------------------------------------------------------------------------------*/
55

66
import { TPromise } from 'vs/base/common/winjs.base';
7-
import URI from 'vs/base/common/uri';
87
import { createDecorator } from 'vs/platform/instantiation/common/instantiation';
98
import Event from 'vs/base/common/event';
109

src/vs/platform/configuration/common/model.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -136,8 +136,8 @@ export class ConfigModel<T> implements IConfigModel<T> {
136136
public languageConfig<V>(language: string): ConfigModel<V> {
137137
const result = new ConfigModel<V>(null);
138138
const contents = objects.clone<any>(this.contents);
139-
if (this._overrides) {
140-
for (const override of this._overrides) {
139+
if (this.overrides) {
140+
for (const override of this.overrides) {
141141
if (override.languages.indexOf(language) !== -1) {
142142
merge(contents, override.contents, true);
143143
}

src/vs/platform/configuration/node/configurationService.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,11 @@
55
'use strict';
66

77
import { TPromise } from 'vs/base/common/winjs.base';
8-
import URI from 'vs/base/common/uri';
9-
import * as glob from 'vs/base/common/glob';
108
import * as objects from 'vs/base/common/objects';
119
import { ConfigWatcher } from 'vs/base/node/config';
1210
import { Registry } from 'vs/platform/platform';
1311
import { IConfigurationRegistry, Extensions } from 'vs/platform/configuration/common/configurationRegistry';
14-
import { IDisposable, dispose, toDisposable, Disposable } from 'vs/base/common/lifecycle';
12+
import { IDisposable, toDisposable, Disposable } from 'vs/base/common/lifecycle';
1513
import { ConfigurationSource, IConfigurationService, IConfigurationServiceEvent, IConfigurationValue, getConfigurationValue, IConfigurationKeys, IConfigModel, IConfigurationOptions } from 'vs/platform/configuration/common/configuration';
1614
import { ConfigModel, DefaultConfigModel } from 'vs/platform/configuration/common/model';
1715
import Event, { Emitter } from 'vs/base/common/event';

src/vs/workbench/services/configuration/node/configurationService.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,11 @@ import { RunOnceScheduler } from 'vs/base/common/async';
1414
import collections = require('vs/base/common/collections');
1515
import { IWorkspaceContextService } from 'vs/platform/workspace/common/workspace';
1616
import { IEnvironmentService } from 'vs/platform/environment/common/environment';
17-
import { IDisposable, dispose, Disposable } from 'vs/base/common/lifecycle';
17+
import { IDisposable, Disposable } from 'vs/base/common/lifecycle';
1818
import { readFile } from 'vs/base/node/pfs';
1919
import errors = require('vs/base/common/errors');
2020
import { ScopedConfigModel, WorkspaceConfigModel } from 'vs/workbench/services/configuration/common/model';
21-
import { IConfigurationServiceEvent, ConfigurationSource, getConfigurationValue, IConfigModel, IOverrides, IConfigurationOptions } from 'vs/platform/configuration/common/configuration';
21+
import { IConfigurationServiceEvent, ConfigurationSource, getConfigurationValue, IConfigModel, IConfigurationOptions } from 'vs/platform/configuration/common/configuration';
2222
import { ConfigModel } from 'vs/platform/configuration/common/model';
2323
import { ConfigurationService as BaseConfigurationService } from 'vs/platform/configuration/node/configurationService';
2424
import { IWorkspaceConfigurationValues, IWorkspaceConfigurationService, IWorkspaceConfigurationValue, CONFIG_DEFAULT_NAME, WORKSPACE_CONFIG_FOLDER_DEFAULT_NAME, WORKSPACE_STANDALONE_CONFIGURATIONS, WORKSPACE_CONFIG_DEFAULT_PATH } from 'vs/workbench/services/configuration/common/configuration';

0 commit comments

Comments
 (0)