better name for global, simpler util for workbench.js, microsoft#101850

jrieken · jrieken · commit 295923e19dfc · 2020-07-08T11:39:09.000+02:00
diff --git a/src/vs/base/common/performance.js b/src/vs/base/common/performance.js
@@ -9,22 +9,22 @@
 
 function _factory(sharedObj) {
 
-	sharedObj._performanceEntries = sharedObj._performanceEntries || [];
+	sharedObj.MonacoPerformanceMarks = sharedObj.MonacoPerformanceMarks || [];
 
 	const _dataLen = 2;
 	const _timeStamp = typeof console.timeStamp === 'function' ? console.timeStamp.bind(console) : () => { };
 
 	function importEntries(entries) {
-		sharedObj._performanceEntries.splice(0, 0, ...entries);
+		sharedObj.MonacoPerformanceMarks.splice(0, 0, ...entries);
 	}
 
 	function exportEntries() {
-		return sharedObj._performanceEntries.slice(0);
+		return sharedObj.MonacoPerformanceMarks.slice(0);
 	}
 
 	function getEntries() {
 		const result = [];
-		const entries = sharedObj._performanceEntries;
+		const entries = sharedObj.MonacoPerformanceMarks;
 		for (let i = 0; i < entries.length; i += _dataLen) {
 			result.push({
 				name: entries[i],
@@ -35,7 +35,7 @@ function _factory(sharedObj) {
 	}
 
 	function getDuration(from, to) {
-		const entries = sharedObj._performanceEntries;
+		const entries = sharedObj.MonacoPerformanceMarks;
 		let target = to;
 		let endIndex = 0;
 		for (let i = entries.length - _dataLen; i >= 0; i -= _dataLen) {
@@ -54,7 +54,7 @@ function _factory(sharedObj) {
 	}
 
 	function mark(name) {
-		sharedObj._performanceEntries.push(name, Date.now());
+		sharedObj.MonacoPerformanceMarks.push(name, Date.now());
 		_timeStamp(name);
 	}
 
diff --git a/src/vs/code/electron-browser/workbench/workbench.js b/src/vs/code/electron-browser/workbench/workbench.js
@@ -9,24 +9,13 @@
 'use strict';
 
 const perf = (function () {
-	let sharedObj;
-	if (typeof global === 'object') {
-		// nodejs
-		sharedObj = global;
-	} else if (typeof self === 'object') {
-		// browser
-		sharedObj = self;
-	} else {
-		sharedObj = {};
-	}
-	// @ts-ignore
-	sharedObj._performanceEntries = sharedObj._performanceEntries || [];
+	globalThis.MonacoPerformanceMarks = globalThis.MonacoPerformanceMarks || [];
 	return {
 		/**
 		 * @param {string} name
 		 */
 		mark(name) {
-			sharedObj._performanceEntries.push(name, Date.now());
+			globalThis.MonacoPerformanceMarks.push(name, Date.now());
 		}
 	};
 })();
