Remote getLogLocation API

sandy081 · sandy081 · commit 27bb0131b07f · 2018-09-07T12:04:53.000+02:00
diff --git a/src/vs/workbench/services/commands/test/common/commandService.test.ts b/src/vs/workbench/services/commands/test/common/commandService.test.ts
@@ -14,7 +14,6 @@ import { InstantiationService } from 'vs/platform/instantiation/common/instantia
 import { IExtensionPoint } from 'vs/workbench/services/extensions/common/extensionsRegistry';
 import { Event, Emitter } from 'vs/base/common/event';
 import { NullLogService } from 'vs/platform/log/common/log';
-import { URI } from 'vs/base/common/uri';
 
 class SimpleExtensionService implements IExtensionService {
 	_serviceBrand: any;
@@ -38,7 +37,6 @@ class SimpleExtensionService implements IExtensionService {
 	getExtensions(): TPromise<IExtensionDescription[]> {
 		return TPromise.wrap([]);
 	}
-	getLogsLocations(): TPromise<URI[]> { return TPromise.as([]); }
 	canProfileExtensionHost() {
 		return false;
 	}
diff --git a/src/vs/workbench/services/extensions/common/extensions.ts b/src/vs/workbench/services/extensions/common/extensions.ts
@@ -153,11 +153,6 @@ export interface IExtensionService {
 	 */
 	getExtensions(): TPromise<IExtensionDescription[]>;
 
-	/**
-	 * Return extension host log folder paths
-	 */
-	getLogsLocations(): TPromise<URI[]>;
-
 	/**
 	 * Read all contributions to an extension point.
 	 */
diff --git a/src/vs/workbench/services/extensions/electron-browser/extensionService.ts b/src/vs/workbench/services/extensions/electron-browser/extensionService.ts
@@ -438,10 +438,6 @@ export class ExtensionService extends Disposable implements IExtensionService {
 		});
 	}
 
-	public getLogsLocations(): TPromise<URI[]> {
-		return TPromise.as([this._extensionHostLogsLocation]);
-	}
-
 	public readExtensionPointContributions<T>(extPoint: IExtensionPoint<T>): TPromise<ExtensionPointContribution<T>[]> {
 		return this._installedExtensionsReady.wait().then(() => {
 			let availableExtensions = this._registry.getAllExtensionDescriptions();
diff --git a/src/vs/workbench/test/workbenchTestServices.ts b/src/vs/workbench/test/workbenchTestServices.ts
@@ -307,7 +307,6 @@ export class TestExtensionService implements IExtensionService {
 	activateByEvent(activationEvent: string): TPromise<void> { return TPromise.as(void 0); }
 	whenInstalledExtensionsRegistered(): TPromise<boolean> { return TPromise.as(true); }
 	getExtensions(): TPromise<IExtensionDescription[]> { return TPromise.as([]); }
-	getLogsLocations(): TPromise<URI[]> { return TPromise.as([]); }
 	readExtensionPointContributions<T>(extPoint: IExtensionPoint<T>): TPromise<ExtensionPointContribution<T>[]> { return TPromise.as(Object.create(null)); }
 	getExtensionsStatus(): { [id: string]: IExtensionsStatus; } { return Object.create(null); }
 	canProfileExtensionHost(): boolean { return false; }

Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,6 @@ import { InstantiationService } from 'vs/platform/instantiation/common/instantia`
`14`	`14`	`import { IExtensionPoint } from 'vs/workbench/services/extensions/common/extensionsRegistry';`
`15`	`15`	`import { Event, Emitter } from 'vs/base/common/event';`
`16`	`16`	`import { NullLogService } from 'vs/platform/log/common/log';`
`17`		`-import { URI } from 'vs/base/common/uri';`
`18`	`17`
`19`	`18`	`class SimpleExtensionService implements IExtensionService {`
`20`	`19`	`_serviceBrand: any;`
`@@ -38,7 +37,6 @@ class SimpleExtensionService implements IExtensionService {`
`38`	`37`	`getExtensions(): TPromise<IExtensionDescription[]> {`
`39`	`38`	`return TPromise.wrap([]);`
`40`	`39`	`}`
`41`		`- getLogsLocations(): TPromise<URI[]> { return TPromise.as([]); }`
`42`	`40`	`canProfileExtensionHost() {`
`43`	`41`	`return false;`
`44`	`42`	`}`