💄 forof over foreach

jrieken · jrieken · commit 26605048eabb · 2020-08-12T16:16:00.000+02:00
diff --git a/src/vs/workbench/api/common/extHostNotebook.ts b/src/vs/workbench/api/common/extHostNotebook.ts
@@ -1517,7 +1517,7 @@ export class ExtHostNotebookController implements ExtHostNotebookShape, ExtHostN
 		let editorChanged = false;
 
 		if (delta.removedDocuments) {
-			delta.removedDocuments.forEach((uri) => {
+			for (const uri of delta.removedDocuments) {
 				const revivedUri = URI.revive(uri);
 				const document = this._documents.get(revivedUri);
 
@@ -1528,21 +1528,21 @@ export class ExtHostNotebookController implements ExtHostNotebookShape, ExtHostN
 					this._onDidCloseNotebookDocument.fire(document);
 				}
 
-				[...this._editors.values()].forEach((e) => {
+				for (const e of this._editors.values()) {
 					if (e.editor.uri.toString() === revivedUri.toString()) {
 						e.editor.dispose();
 						this._editors.delete(e.editor.id);
 						editorChanged = true;
 					}
-				});
-			});
+				}
+			}
 		}
 
 		if (delta.addedDocuments) {
 
 			const addedCellDocuments: IModelAddedData[] = [];
 
-			delta.addedDocuments.forEach(modelData => {
+			for (const modelData of delta.addedDocuments) {
 				const revivedUri = URI.revive(modelData.uri);
 				const viewType = modelData.viewType;
 				const entry = this._notebookContentProviders.get(viewType);
@@ -1606,11 +1606,11 @@ export class ExtHostNotebookController implements ExtHostNotebookShape, ExtHostN
 
 				const document = this._documents.get(revivedUri)!;
 				this._onDidOpenNotebookDocument.fire(document);
-			});
+			}
 		}
 
 		if (delta.addedEditors) {
-			delta.addedEditors.forEach(editorModelData => {
+			for (const editorModelData of delta.addedEditors) {
 				if (this._editors.has(editorModelData.id)) {
 					return;
 				}
@@ -1622,13 +1622,13 @@ export class ExtHostNotebookController implements ExtHostNotebookShape, ExtHostN
 					this._createExtHostEditor(document, editorModelData.id, editorModelData.selections);
 					editorChanged = true;
 				}
-			});
+			}
 		}
 
 		const removedEditors: { editor: ExtHostNotebookEditor; }[] = [];
 
 		if (delta.removedEditors) {
-			delta.removedEditors.forEach(editorid => {
+			for (const editorid of delta.removedEditors) {
 				const editor = this._editors.get(editorid);
 
 				if (editor) {
@@ -1641,7 +1641,7 @@ export class ExtHostNotebookController implements ExtHostNotebookShape, ExtHostN
 
 					removedEditors.push(editor);
 				}
-			});
+			}
 		}
 
 		if (editorChanged) {
@@ -1655,10 +1655,10 @@ export class ExtHostNotebookController implements ExtHostNotebookShape, ExtHostN
 			const visibleEditorsSet = new Set<string>();
 			this.visibleNotebookEditors.forEach(editor => visibleEditorsSet.add(editor.id));
 
-			[...this._editors.values()].forEach((e) => {
+			for (const e of this._editors.values()) {
 				const newValue = visibleEditorsSet.has(e.editor.id);
 				e.editor._acceptVisibility(newValue);
-			});
+			}
 
 			this.visibleNotebookEditors = [...this._editors.values()].map(e => e.editor).filter(e => e.visible);
 			this._onDidChangeVisibleNotebookEditors.fire(this.visibleNotebookEditors);
@@ -1668,19 +1668,17 @@ export class ExtHostNotebookController implements ExtHostNotebookShape, ExtHostN
 			if (delta.newActiveEditor) {
 				this._activeNotebookEditor = this._editors.get(delta.newActiveEditor)?.editor;
 				this._activeNotebookEditor?._acceptActive(true);
-				[...this._editors.values()].forEach((e) => {
+				for (const e of this._editors.values()) {
 					if (e.editor !== this.activeNotebookEditor) {
 						e.editor._acceptActive(false);
 					}
-				});
+				}
 			} else {
 				// clear active notebook as current active editor is non-notebook editor
 				this._activeNotebookEditor = undefined;
-
-				[...this._editors.values()].forEach((e) => {
+				for (const e of this._editors.values()) {
 					e.editor._acceptActive(false);
-				});
-
+				}
 			}
 
 			this._onDidChangeActiveNotebookEditor.fire(this._activeNotebookEditor);
