web - log info when unload is triggered

Benjamin Pasero · Benjamin Pasero · commit 230cb190782b · 2020-03-13T10:35:56.000+01:00
diff --git a/src/vs/workbench/services/lifecycle/browser/lifecycleService.ts b/src/vs/workbench/services/lifecycle/browser/lifecycleService.ts
@@ -28,6 +28,9 @@ export class BrowserLifecycleService extends AbstractLifecycleService {
 	}
 
 	private onBeforeUnload(): string | null {
+		const logService = this.logService;
+		logService.info('[lifecycle] onBeforeUnload triggered');
+
 		let veto = false;
 
 		// Before Shutdown
@@ -36,7 +39,7 @@ export class BrowserLifecycleService extends AbstractLifecycleService {
 				if (value === true) {
 					veto = true;
 				} else if (value instanceof Promise && !veto) {
-					console.warn(new Error('Long running onBeforeShutdown currently not supported in the web'));
+					logService.error('[lifecycle] Long running onBeforeShutdown currently not supported in the web');
 					veto = true;
 				}
 			},
@@ -51,7 +54,7 @@ export class BrowserLifecycleService extends AbstractLifecycleService {
 		// No Veto: continue with Will Shutdown
 		this._onWillShutdown.fire({
 			join() {
-				console.warn(new Error('Long running onWillShutdown currently not supported in the web'));
+				logService.error('[lifecycle] Long running onWillShutdown currently not supported in the web');
 			},
 			reason: ShutdownReason.QUIT
 		});
