Skip to content

Commit 2147b8a

Browse files
author
Benjamin Pasero
committed
web - enable feedback contribution
1 parent 35b9b7f commit 2147b8a

6 files changed

Lines changed: 30 additions & 8 deletions

File tree

src/vs/workbench/contrib/preferences/browser/preferencesSearch.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ import { nullRange } from 'vs/workbench/services/preferences/common/preferencesM
2525
import { IConfigurationService } from 'vs/platform/configuration/common/configuration';
2626
import { IStringDictionary } from 'vs/base/common/collections';
2727
import { IProductService } from 'vs/platform/product/common/product';
28+
import { registerSingleton } from 'vs/platform/instantiation/common/extensions';
2829

2930
export interface IEndpointDetails {
3031
urlBase?: string;
@@ -564,3 +565,5 @@ export class SettingMatches {
564565
};
565566
}
566567
}
568+
569+
registerSingleton(IPreferencesSearchService, PreferencesSearchService, true);
Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
/*---------------------------------------------------------------------------------------------
2+
* Copyright (c) Microsoft Corporation. All rights reserved.
3+
* Licensed under the MIT License. See License.txt in the project root for license information.
4+
*--------------------------------------------------------------------------------------------*/
5+
6+
import { IIntegrityService, IntegrityTestResult } from 'vs/workbench/services/integrity/common/integrity';
7+
import { registerSingleton } from 'vs/platform/instantiation/common/extensions';
8+
import { ServiceIdentifier } from 'vs/platform/instantiation/common/instantiation';
9+
10+
export class BrowserIntegrityServiceImpl implements IIntegrityService {
11+
12+
_serviceBrand!: ServiceIdentifier<any>;
13+
14+
async isPure(): Promise<IntegrityTestResult> {
15+
return { isPure: true, proof: [] };
16+
}
17+
}
18+
19+
registerSingleton(IIntegrityService, BrowserIntegrityServiceImpl, true);

src/vs/workbench/services/integrity/node/integrityService.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import product from 'vs/platform/product/node/product';
1414
import { INotificationService } from 'vs/platform/notification/common/notification';
1515
import { IStorageService, StorageScope } from 'vs/platform/storage/common/storage';
1616
import { registerSingleton } from 'vs/platform/instantiation/common/extensions';
17+
import { ServiceIdentifier } from 'vs/platform/instantiation/common/instantiation';
1718

1819
interface IStorageData {
1920
dontShowPrompt: boolean;
@@ -55,7 +56,7 @@ class IntegrityStorage {
5556

5657
export class IntegrityServiceImpl implements IIntegrityService {
5758

58-
_serviceBrand: any;
59+
_serviceBrand!: ServiceIdentifier<any>;
5960

6061
private _storage: IntegrityStorage;
6162
private _isPurePromise: Promise<IntegrityTestResult>;
@@ -159,4 +160,4 @@ export class IntegrityServiceImpl implements IIntegrityService {
159160
}
160161
}
161162

162-
registerSingleton(IIntegrityService, IntegrityServiceImpl, true);
163+
registerSingleton(IIntegrityService, IntegrityServiceImpl, true);

src/vs/workbench/workbench.common.main.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -123,9 +123,7 @@ import 'vs/workbench/contrib/telemetry/browser/telemetry.contribution';
123123
// Preferences
124124
import 'vs/workbench/contrib/preferences/browser/preferences.contribution';
125125
import 'vs/workbench/contrib/preferences/browser/keybindingsEditorContribution';
126-
import { IPreferencesSearchService } from 'vs/workbench/contrib/preferences/common/preferences';
127-
import { PreferencesSearchService } from 'vs/workbench/contrib/preferences/browser/preferencesSearch';
128-
registerSingleton(IPreferencesSearchService, PreferencesSearchService, true);
126+
import 'vs/workbench/contrib/preferences/browser/preferencesSearch';
129127

130128
// Logs
131129
import 'vs/workbench/contrib/logs/common/logs.contribution';
@@ -231,4 +229,7 @@ import 'vs/workbench/contrib/outline/browser/outline.contribution';
231229
// Experiments
232230
import 'vs/workbench/contrib/experiments/browser/experiments.contribution';
233231

232+
// Send a Smile
233+
import 'vs/workbench/contrib/feedback/browser/feedback.contribution';
234+
234235
//#endregion

src/vs/workbench/workbench.desktop.main.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -131,9 +131,6 @@ import 'vs/workbench/contrib/codeEditor/electron-browser/codeEditor.contribution
131131
// Execution
132132
import 'vs/workbench/contrib/externalTerminal/node/externalTerminalService';
133133

134-
// Send a Smile
135-
import 'vs/workbench/contrib/feedback/browser/feedback.contribution';
136-
137134
// Update
138135
import 'vs/workbench/contrib/update/electron-browser/update.contribution';
139136

src/vs/workbench/workbench.web.main.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ import 'vs/workbench/browser/web.main';
2626

2727

2828
//#region --- workbench services
29+
import 'vs/workbench/services/integrity/browser/integrityService';
2930
import 'vs/workbench/services/textMate/browser/textMateService';
3031
import 'vs/workbench/services/search/common/searchService';
3132
import 'vs/workbench/services/output/common/outputChannelModelService';

0 commit comments

Comments
 (0)