sandbox - 💄

Benjamin Pasero · Benjamin Pasero · commit 20e5950f5459 · 2020-09-17T16:49:27.000+02:00
diff --git a/src/vs/platform/diagnostics/node/diagnosticsService.ts b/src/vs/platform/diagnostics/node/diagnosticsService.ts
@@ -14,7 +14,7 @@ import { repeat, pad } from 'vs/base/common/strings';
 import { isWindows, isLinux } from 'vs/base/common/platform';
 import { URI } from 'vs/base/common/uri';
 import { ProcessItem } from 'vs/base/common/processes';
-import { IMainProcessInfo } from 'vs/platform/launch/common/launch';
+import { IMainProcessInfo } from 'vs/platform/launch/node/launch';
 import { ITelemetryService } from 'vs/platform/telemetry/common/telemetry';
 import { createDecorator } from 'vs/platform/instantiation/common/instantiation';
 import { Iterable } from 'vs/base/common/iterator';
diff --git a/src/vs/platform/launch/electron-main/launchMainService.ts b/src/vs/platform/launch/electron-main/launchMainService.ts
@@ -18,7 +18,7 @@ import { URI } from 'vs/base/common/uri';
 import { BrowserWindow, ipcMain, Event as IpcEvent, app } from 'electron';
 import { coalesce } from 'vs/base/common/arrays';
 import { IDiagnosticInfoOptions, IDiagnosticInfo, IRemoteDiagnosticInfo, IRemoteDiagnosticError } from 'vs/platform/diagnostics/common/diagnostics';
-import { IMainProcessInfo, IWindowInfo } from 'vs/platform/launch/common/launch';
+import { IMainProcessInfo, IWindowInfo } from 'vs/platform/launch/node/launch';
 
 export const ID = 'launchMainService';
 export const ILaunchMainService = createDecorator<ILaunchMainService>(ID);
diff --git a/src/vs/platform/launch/node/launch.ts b/src/vs/platform/launch/node/launch.ts
diff --git a/src/vs/platform/native/electron-sandbox/native.ts b/src/vs/platform/native/electron-sandbox/native.ts
@@ -8,4 +8,11 @@ import { ICommonNativeHostService } from 'vs/platform/native/common/native';
 
 export const INativeHostService = createDecorator<INativeHostService>('nativeHostService');
 
+/**
+ * A set of methods specific to a native host, i.e. unsupported in web
+ * environments.
+ *
+ * @see `IHostService` for methods that can be used in native and web
+ * hosts.
+ */
 export interface INativeHostService extends ICommonNativeHostService { }
diff --git a/src/vs/platform/sign/browser/signService.ts b/src/vs/platform/sign/browser/signService.ts
@@ -16,6 +16,6 @@ export class SignService implements ISignService {
 	}
 
 	async sign(value: string): Promise<string> {
-		return Promise.resolve(this._tkn || '');
+		return this._tkn || '';
 	}
 }
diff --git a/src/vs/platform/theme/browser/checkbox.ts b/src/vs/platform/theme/browser/checkbox.ts
diff --git a/src/vs/workbench/contrib/preferences/browser/keybindingsEditor.ts b/src/vs/workbench/contrib/preferences/browser/keybindingsEditor.ts
@@ -46,7 +46,7 @@ import { IListAccessibilityProvider } from 'vs/base/browser/ui/list/listWidget';
 import { preferencesEditIcon } from 'vs/workbench/contrib/preferences/browser/preferencesWidgets';
 import { Color, RGBA } from 'vs/base/common/color';
 import { WORKBENCH_BACKGROUND } from 'vs/workbench/common/theme';
-import { ThemableCheckboxActionViewItem } from 'vs/platform/browser/checkbox';
+import { ThemableCheckboxActionViewItem } from 'vs/platform/theme/browser/checkbox';
 
 const $ = DOM.$;
 
diff --git a/src/vs/workbench/services/host/browser/host.ts b/src/vs/workbench/services/host/browser/host.ts
@@ -9,6 +9,12 @@ import { IWindowOpenable, IOpenWindowOptions, IOpenEmptyWindowOptions } from 'vs
 
 export const IHostService = createDecorator<IHostService>('hostService');
 
+/**
+ * A set of methods supported in both web and native environments.
+ *
+ * @see `INativeHostService` for methods that are specific to native
+ * environments.
+ */
 export interface IHostService {
 
 	readonly _serviceBrand: undefined;

Original file line number	Diff line number	Diff line change
`@@ -16,6 +16,6 @@ export class SignService implements ISignService {`
`16`	`16`	`}`
`17`	`17`
`18`	`18`	`async sign(value: string): Promise<string> {`
`19`		`- return Promise.resolve(this._tkn \|\| '');`
	`19`	`+ return this._tkn \|\| '';`
`20`	`20`	`}`
`21`	`21`	`}`