Skip to content

Commit 1e4fcba

Browse files
author
Benjamin Pasero
committed
web - disable some flaky integration tests (microsoft#92826)
1 parent 3e32ce7 commit 1e4fcba

1 file changed

Lines changed: 5 additions & 3 deletions

File tree

extensions/vscode-api-tests/src/singlefolder-tests/terminal.test.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
* Licensed under the MIT License. See License.txt in the project root for license information.
44
*--------------------------------------------------------------------------------------------*/
55

6-
import { window, Pseudoterminal, EventEmitter, TerminalDimensions, workspace, ConfigurationTarget, Disposable } from 'vscode';
6+
import { window, Pseudoterminal, EventEmitter, TerminalDimensions, workspace, ConfigurationTarget, Disposable, UIKind, env } from 'vscode';
77
import { doesNotThrow, equal, ok, deepEqual, throws } from 'assert';
88

99
suite('window namespace tests', () => {
@@ -19,7 +19,8 @@ suite('window namespace tests', () => {
1919
disposables.length = 0;
2020
});
2121

22-
test('sendText immediately after createTerminal should not throw', (done) => {
22+
// TODO@Daniel flaky test (https://github.com/microsoft/vscode/issues/92826)
23+
((env.uiKind === UIKind.Web) ? test.skip : test)('sendText immediately after createTerminal should not throw', (done) => {
2324
disposables.push(window.onDidOpenTerminal(term => {
2425
try {
2526
equal(terminal, term);
@@ -33,7 +34,8 @@ suite('window namespace tests', () => {
3334
doesNotThrow(terminal.sendText.bind(terminal, 'echo "foo"'));
3435
});
3536

36-
test('onDidCloseTerminal event fires when terminal is disposed', (done) => {
37+
// TODO@Daniel done called multiple times (https://github.com/microsoft/vscode/issues/92826)
38+
((env.uiKind === UIKind.Web) ? test.skip : test)('onDidCloseTerminal event fires when terminal is disposed', (done) => {
3739
disposables.push(window.onDidOpenTerminal(term => {
3840
try {
3941
equal(terminal, term);

0 commit comments

Comments
 (0)