Fixed failing test

dbaeumer · dbaeumer · commit 1cc381c729f7 · 2018-03-12T12:46:47.000+01:00
diff --git a/src/vs/workbench/parts/tasks/node/taskConfiguration.ts b/src/vs/workbench/parts/tasks/node/taskConfiguration.ts
@@ -849,7 +849,7 @@ namespace CommandConfiguration {
 			result.args = [];
 			for (let arg of config.args) {
 				let converted = ShellString.from(arg);
-				if (converted) {
+				if (converted !== void 0) {
 					result.args.push(converted);
 				} else {
 					context.problemReporter.error(nls.localize('ConfigurationParser.inValidArg', 'Error: command argument must either be a string or a quoted string. Provided value is:\n{0}', context.problemReporter.error(nls.localize('ConfigurationParser.noargs', 'Error: command arguments must be an array of strings. Provided value is:\n{0}', arg ? JSON.stringify(arg, undefined, 4) : 'undefined'))));
diff --git a/src/vs/workbench/parts/tasks/test/electron-browser/configuration.test.ts b/src/vs/workbench/parts/tasks/test/electron-browser/configuration.test.ts
@@ -1648,7 +1648,6 @@ suite('Bugs / regression tests', () => {
 		}
 	});
 
-	/*
 	test('Bug 28489', () => {
 		let external = {
 			version: '0.1.0',
@@ -1674,5 +1673,4 @@ suite('Bugs / regression tests', () => {
 			runtime(Tasks.RuntimeType.Shell);
 		testConfiguration(external, builder);
 	});
-	*/
 });
