Skip to content

Commit 1b70625

Browse files
mjbvzmjbvz
committed
Use import type when importing vscode under src
When the core references `vscode`, we only want to import the types and never generate a real import (which will fail to load). Use `import type` to better enforce this
1 parent d2911af commit 1b70625

49 files changed

Lines changed: 49 additions & 49 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎src/vs/workbench/api/common/apiCommands.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
* Licensed under the MIT License. See License.txt in the project root for license information.
44
*--------------------------------------------------------------------------------------------*/
55

6-
import * as vscode from 'vscode';
6+
import type * as vscode from 'vscode';
77
import { URI } from 'vs/base/common/uri';
88
import * as typeConverters from 'vs/workbench/api/common/extHostTypeConverters';
99
import { CommandsRegistry, ICommandService, ICommandHandler } from 'vs/platform/commands/common/commands';

‎src/vs/workbench/api/common/extHostApiCommands.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
import { URI } from 'vs/base/common/uri';
77
import { DisposableStore, IDisposable } from 'vs/base/common/lifecycle';
8-
import * as vscode from 'vscode';
8+
import type * as vscode from 'vscode';
99
import * as typeConverters from 'vs/workbench/api/common/extHostTypeConverters';
1010
import * as types from 'vs/workbench/api/common/extHostTypes';
1111
import { IRawColorInfo, IWorkspaceEditDto, ICallHierarchyItemDto, IIncomingCallDto, IOutgoingCallDto } from 'vs/workbench/api/common/extHost.protocol';

‎src/vs/workbench/api/common/extHostClipboard.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
*--------------------------------------------------------------------------------------------*/
55

66
import { IMainContext, MainContext, MainThreadClipboardShape } from 'vs/workbench/api/common/extHost.protocol';
7-
import * as vscode from 'vscode';
7+
import type * as vscode from 'vscode';
88

99
export class ExtHostClipboard implements vscode.Clipboard {
1010

‎src/vs/workbench/api/common/extHostCodeInsets.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import { DisposableStore } from 'vs/base/common/lifecycle';
88
import { IExtensionDescription } from 'vs/platform/extensions/common/extensions';
99
import { ExtHostTextEditor } from 'vs/workbench/api/common/extHostTextEditor';
1010
import { ExtHostEditors } from 'vs/workbench/api/common/extHostTextEditors';
11-
import * as vscode from 'vscode';
11+
import type * as vscode from 'vscode';
1212
import { ExtHostEditorInsetsShape, MainThreadEditorInsetsShape } from './extHost.protocol';
1313
import { asWebviewUri, WebviewInitData } from 'vs/workbench/api/common/shared/webview';
1414
import { generateUuid } from 'vs/base/common/uuid';

‎src/vs/workbench/api/common/extHostCommands.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import { cloneAndChange } from 'vs/base/common/objects';
1111
import { MainContext, MainThreadCommandsShape, ExtHostCommandsShape, ObjectIdentifier, ICommandDto } from './extHost.protocol';
1212
import { isNonEmptyArray } from 'vs/base/common/arrays';
1313
import * as modes from 'vs/editor/common/modes';
14-
import * as vscode from 'vscode';
14+
import type * as vscode from 'vscode';
1515
import { ILogService } from 'vs/platform/log/common/log';
1616
import { revive } from 'vs/base/common/marshalling';
1717
import { Range } from 'vs/editor/common/core/range';

‎src/vs/workbench/api/common/extHostComments.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import { ExtensionIdentifier, IExtensionDescription } from 'vs/platform/extensio
1515
import { ExtHostDocuments } from 'vs/workbench/api/common/extHostDocuments';
1616
import * as extHostTypeConverter from 'vs/workbench/api/common/extHostTypeConverters';
1717
import * as types from 'vs/workbench/api/common/extHostTypes';
18-
import * as vscode from 'vscode';
18+
import type * as vscode from 'vscode';
1919
import { ExtHostCommentsShape, IMainContext, MainContext, MainThreadCommentsShape, CommentThreadChanges } from './extHost.protocol';
2020
import { ExtHostCommands } from './extHostCommands';
2121

‎src/vs/workbench/api/common/extHostConfiguration.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
import { mixin, deepClone } from 'vs/base/common/objects';
77
import { Event, Emitter } from 'vs/base/common/event';
8-
import * as vscode from 'vscode';
8+
import type * as vscode from 'vscode';
99
import { ExtHostWorkspace, IExtHostWorkspace } from 'vs/workbench/api/common/extHostWorkspace';
1010
import { ExtHostConfigurationShape, MainThreadConfigurationShape, IConfigurationInitData, MainContext } from './extHost.protocol';
1111
import { ConfigurationTarget as ExtHostConfigurationTarget } from './extHostTypes';

‎src/vs/workbench/api/common/extHostDebugService.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ import { IExtHostCommands } from 'vs/workbench/api/common/extHostCommands';
2727
import { ExtensionDescriptionRegistry } from 'vs/workbench/services/extensions/common/extensionDescriptionRegistry';
2828
import { ISignService } from 'vs/platform/sign/common/sign';
2929
import { IExtHostRpcService } from 'vs/workbench/api/common/extHostRpcService';
30-
import * as vscode from 'vscode';
30+
import type * as vscode from 'vscode';
3131
import { IExtensionDescription } from 'vs/platform/extensions/common/extensions';
3232
import { createDecorator } from 'vs/platform/instantiation/common/instantiation';
3333
import { withNullAsUndefined } from 'vs/base/common/types';

‎src/vs/workbench/api/common/extHostDecorations.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
* Licensed under the MIT License. See License.txt in the project root for license information.
44
*--------------------------------------------------------------------------------------------*/
55

6-
import * as vscode from 'vscode';
6+
import type * as vscode from 'vscode';
77
import { URI } from 'vs/base/common/uri';
88
import { MainContext, ExtHostDecorationsShape, MainThreadDecorationsShape, DecorationData, DecorationRequest, DecorationReply } from 'vs/workbench/api/common/extHost.protocol';
99
import { Disposable, Decoration } from 'vs/workbench/api/common/extHostTypes';

‎src/vs/workbench/api/common/extHostDiagnostics.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
import { localize } from 'vs/nls';
77
import { IMarkerData, MarkerSeverity } from 'vs/platform/markers/common/markers';
88
import { URI, UriComponents } from 'vs/base/common/uri';
9-
import * as vscode from 'vscode';
9+
import type * as vscode from 'vscode';
1010
import { MainContext, MainThreadDiagnosticsShape, ExtHostDiagnosticsShape, IMainContext } from './extHost.protocol';
1111
import { DiagnosticSeverity } from './extHostTypes';
1212
import * as converter from './extHostTypeConverters';

0 commit comments

Comments
 (0)