Merge pull request microsoft#76054 from microsoft/tyriar/76032_cmd_track_bug

Tyriar · web-flow · commit 17b5a459f355 · 2019-06-26T10:59:04.000-07:00
Floor scrolled line in command tracking
diff --git a/src/vs/workbench/contrib/terminal/browser/terminalCommandTracker.ts b/src/vs/workbench/contrib/terminal/browser/terminalCommandTracker.ts
@@ -112,7 +112,7 @@ export class TerminalCommandTracker implements ITerminalCommandTracker, IDisposa
 	private _scrollToMarker(marker: IMarker, position: ScrollPosition): void {
 		let line = marker.line;
 		if (position === ScrollPosition.Middle) {
-			line = Math.max(line - this._xterm.rows / 2, 0);
+			line = Math.max(line - Math.floor(this._xterm.rows / 2), 0);
 		}
 		this._xterm.scrollToLine(line);
 	}

Original file line number	Diff line number	Diff line change
`@@ -112,7 +112,7 @@ export class TerminalCommandTracker implements ITerminalCommandTracker, IDisposa`
`112`	`112`	`private _scrollToMarker(marker: IMarker, position: ScrollPosition): void {`
`113`	`113`	`let line = marker.line;`
`114`	`114`	`if (position === ScrollPosition.Middle) {`
`115`		`- line = Math.max(line - this._xterm.rows / 2, 0);`
	`115`	`+ line = Math.max(line - Math.floor(this._xterm.rows / 2), 0);`
`116`	`116`	`}`
`117`	`117`	`this._xterm.scrollToLine(line);`
`118`	`118`	`}`