Add setting to turn off problem matcher prompt

alexr00 · alexr00 · commit 13dc6f18ac59 · 2019-10-10T13:14:45.000+02:00
Fixes microsoft#62728
diff --git a/src/vs/workbench/contrib/tasks/browser/abstractTaskService.ts b/src/vs/workbench/contrib/tasks/browser/abstractTaskService.ts
@@ -674,6 +674,12 @@ export abstract class AbstractTaskService extends Disposable implements ITaskSer
 	}
 
 	private shouldAttachProblemMatcher(task: Task): boolean {
+		const settingValue = this.configurationService.getValue('task.problemMatchers.neverPrompt');
+		if (settingValue === true) {
+			return false;
+		} else if (task.type && Types.isStringArray(settingValue) && (settingValue.indexOf(task.type) >= 0)) {
+			return false;
+		}
 		if (!this.canCustomize(task)) {
 			return false;
 		}
diff --git a/src/vs/workbench/contrib/tasks/browser/task.contribution.ts b/src/vs/workbench/contrib/tasks/browser/task.contribution.ts
@@ -35,6 +35,11 @@ import { IWorkbenchActionRegistry, Extensions as ActionExtensions } from 'vs/wor
 import { RunAutomaticTasks, ManageAutomaticTaskRunning } from 'vs/workbench/contrib/tasks/browser/runAutomaticTasks';
 import { KeybindingsRegistry, KeybindingWeight } from 'vs/platform/keybinding/common/keybindingsRegistry';
 import { KeyMod, KeyCode } from 'vs/base/common/keyCodes';
+import schemaVersion1 from '../common/jsonSchema_v1';
+import schemaVersion2, { updateProblemMatchers } from '../common/jsonSchema_v2';
+import { AbstractTaskService, ConfigureTaskAction } from 'vs/workbench/contrib/tasks/browser/abstractTaskService';
+import { tasksSchemaId } from 'vs/workbench/services/configuration/common/configuration';
+import { IConfigurationRegistry, Extensions } from 'vs/platform/configuration/common/configurationRegistry';
 
 let tasksCategory = nls.localize('tasksCategory', "Tasks");
 
@@ -288,10 +293,6 @@ let schema: IJSONSchema = {
 	}
 };
 
-import schemaVersion1 from '../common/jsonSchema_v1';
-import schemaVersion2, { updateProblemMatchers } from '../common/jsonSchema_v2';
-import { AbstractTaskService, ConfigureTaskAction } from 'vs/workbench/contrib/tasks/browser/abstractTaskService';
-import { tasksSchemaId } from 'vs/workbench/services/configuration/common/configuration';
 schema.definitions = {
 	...schemaVersion1.definitions,
 	...schemaVersion2.definitions,
@@ -305,3 +306,30 @@ ProblemMatcherRegistry.onMatcherChanged(() => {
 	updateProblemMatchers();
 	jsonRegistry.notifySchemaChanged(tasksSchemaId);
 });
+
+const configurationRegistry = Registry.as<IConfigurationRegistry>(Extensions.Configuration);
+configurationRegistry.registerConfiguration({
+	id: 'task',
+	order: 100,
+	title: nls.localize('tasksConfigurationTitle', "Tasks"),
+	type: 'object',
+	properties: {
+		'task.problemMatchers.neverPrompt': {
+			markdownDescription: nls.localize('task.problemMatchers.neverPrompt', "Configures whether to show the problem matcher prompt when running a task. Set to `true` to never promp, or use an array of task types to turn off prompting only for specific task types."),
+			'oneOf': [
+				{
+					type: 'boolean',
+					markdownDescription: nls.localize('task.problemMatchers.neverPrompt.boolean', 'Sets problem matcher prompting behavior for all tasks.')
+				},
+				{
+					type: 'array',
+					items: {
+						type: 'string',
+						markdownDescription: nls.localize('task.problemMatchers.neverPrompt.array', 'An array of task types to never prompt for problem matchers on.')
+					}
+				}
+			],
+			default: false
+		}
+	}
+});

Original file line number	Diff line number	Diff line change
`@@ -674,6 +674,12 @@ export abstract class AbstractTaskService extends Disposable implements ITaskSer`
`674`	`674`	`}`
`675`	`675`
`676`	`676`	`private shouldAttachProblemMatcher(task: Task): boolean {`
	`677`	`+ const settingValue = this.configurationService.getValue('task.problemMatchers.neverPrompt');`
	`678`	`+ if (settingValue === true) {`
	`679`	`+ return false;`
	`680`	`+ } else if (task.type && Types.isStringArray(settingValue) && (settingValue.indexOf(task.type) >= 0)) {`
	`681`	`+ return false;`
	`682`	`+ }`
`677`	`683`	`if (!this.canCustomize(task)) {`
`678`	`684`	`return false;`
`679`	`685`	`}`