bring back: add ignore-certificate-error & allow-insecure-localhost. Clarify unknown option warning

Benjamin Pasero · Benjamin Pasero · commit 13bf3f81eea7 · 2020-01-23T08:24:59.000+01:00
diff --git a/src/vs/platform/environment/common/environment.ts b/src/vs/platform/environment/common/environment.ts
@@ -87,6 +87,8 @@ export interface ParsedArgs {
 	'nolazy'?: boolean;
 	'force-device-scale-factor'?: string;
 	'force-renderer-accessibility'?: boolean;
+	'ignore-certificate-error'?: boolean;
+	'allow-insecure-localhost'?: boolean;
 }
 
 export const IEnvironmentService = createDecorator<IEnvironmentService>('environmentService');
diff --git a/src/vs/platform/environment/node/argv.ts b/src/vs/platform/environment/node/argv.ts
@@ -119,6 +119,8 @@ export const OPTIONS: OptionDescriptions<Required<ParsedArgs>> = {
 	'nolazy': { type: 'boolean' }, // node inspect
 	'force-device-scale-factor': { type: 'string' },
 	'force-renderer-accessibility': { type: 'boolean' },
+	'ignore-certificate-error': { type: 'boolean' },
+	'allow-insecure-localhost': { type: 'boolean' },
 	'_urls': { type: 'string[]' },
 
 	_: { type: 'string[]' } // main arguments
diff --git a/src/vs/platform/environment/node/argvHelper.ts b/src/vs/platform/environment/node/argvHelper.ts
@@ -13,7 +13,7 @@ import { parseArgs, ErrorReporter, OPTIONS } from 'vs/platform/environment/node/
 function parseAndValidate(cmdLineArgs: string[], reportWarnings: boolean): ParsedArgs {
 	const errorReporter: ErrorReporter = {
 		onUnknownOption: (id) => {
-			console.warn(localize('unknownOption', "Option '{0}' is unknown. Ignoring.", id));
+			console.warn(localize('unknownOption', "Warning: '{0}' is not in the list of known options, but still passed to Electron/Chromium.", id));
 		},
 		onMultipleValues: (id, val) => {
 			console.warn(localize('multipleValues', "Option '{0}' is defined more than once. Using value '{1}.'", id, val));

Original file line number	Diff line number	Diff line change
`@@ -87,6 +87,8 @@ export interface ParsedArgs {`
`87`	`87`	`'nolazy'?: boolean;`
`88`	`88`	`'force-device-scale-factor'?: string;`
`89`	`89`	`'force-renderer-accessibility'?: boolean;`
	`90`	`+ 'ignore-certificate-error'?: boolean;`
	`91`	`+ 'allow-insecure-localhost'?: boolean;`
`90`	`92`	`}`
`91`	`93`
`92`	`94`	`export const IEnvironmentService = createDecorator<IEnvironmentService>('environmentService');`