(re)enable no-extra-semi rule

jrieken · jrieken · commit 12eb715644f4 · 2020-01-02T21:12:03.000+01:00
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -19,7 +19,7 @@
         "no-duplicate-case": "warn",
         "no-duplicate-imports": "warn",
         "no-eval": "warn",
-        "no-extra-semi": "off",
+        "no-extra-semi": "warn",
         "no-new-wrappers": "warn",
         "no-redeclare": "off",
         "no-sparse-arrays": "warn",
diff --git a/extensions/vscode-colorize-tests/src/colorizer.test.ts b/extensions/vscode-colorize-tests/src/colorizer.test.ts
@@ -56,7 +56,7 @@ function hasThemeChange(d: any, p: any) : boolean {
 		}
 	}
 	return false;
-};
+}
 
 suite('colorization', () => {
 	let extensionsFolder = normalize(join(__dirname, '../../'));
diff --git a/src/vs/workbench/test/electron-browser/api/extHostDiagnostics.test.ts b/src/vs/workbench/test/electron-browser/api/extHostDiagnostics.test.ts
@@ -34,7 +34,7 @@ suite('ExtHostDiagnostics', () => {
 		assert.throws(() => collection.clear());
 		assert.throws(() => collection.delete(URI.parse('aa:bb')));
 		// tslint:disable-next-line:semicolon
-		assert.throws(() => collection.forEach(() => { ; }));
+		assert.throws(() => collection.forEach(() => { }));
 		assert.throws(() => collection.get(URI.parse('aa:bb')));
 		assert.throws(() => collection.has(URI.parse('aa:bb')));
 		assert.throws(() => collection.set(URI.parse('aa:bb'), []));

Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ function hasThemeChange(d: any, p: any) : boolean {`
`56`	`56`	`}`
`57`	`57`	`}`
`58`	`58`	`return false;`
`59`		`-};`
	`59`	`+}`
`60`	`60`
`61`	`61`	`suite('colorization', () => {`
`62`	`62`	`let extensionsFolder = normalize(join(__dirname, '../../'));`